Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MA/NDMF support to improve compatibility with menu items #44

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

poi-vrc
Copy link
Owner

@poi-vrc poi-vrc commented Mar 11, 2024

No description provided.

@poi-vrc poi-vrc force-pushed the v2-ma-ndmf branch 4 times, most recently from 372a3a3 to 9524127 Compare March 11, 2024 15:45
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 57.34072% with 154 lines in your changes are missing coverage. Please review.

Project coverage is 65.97%. Comparing base (96df571) to head (e513d35).

Files Patch % Lines
Editor/Detail/NDMF/PluginDefinition.cs 0.00% 62 Missing ⚠️
Editor/Detail/NDMF/UnsupportedVersionChecker.cs 0.00% 20 Missing ⚠️
Editor/Detail/DK/DKMAMenuStore.cs 84.29% 19 Missing ⚠️
Editor/Menu/MenuRepositoryStore.cs 76.92% 18 Missing ⚠️
Editor/Detail/NDMF/DKExtensionContext.cs 0.00% 14 Missing ⚠️
Editor/Extensibility/Sequencing/BuildConstraint.cs 52.94% 8 Missing ⚠️
Editor/Detail/NDMF/NDMFContext.cs 46.15% 7 Missing ⚠️
...tor/Detail/NDMF/Passes/CheckDKNDMFCallOrderPass.cs 76.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   68.44%   65.97%   -2.47%     
==========================================
  Files          56       62       +6     
  Lines        2085     2357     +272     
==========================================
+ Hits         1427     1555     +128     
- Misses        658      802     +144     
Flag Coverage Δ
automated 65.97% <57.34%> (-2.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poi-vrc poi-vrc force-pushed the v2-ma-ndmf branch 4 times, most recently from 03004c5 to 9b9b0d2 Compare March 12, 2024 12:54
@poi-vrc poi-vrc marked this pull request as ready for review March 12, 2024 13:13
@poi-vrc poi-vrc force-pushed the v2-ma-ndmf branch 15 times, most recently from 594a832 to c21bf39 Compare March 13, 2024 00:50
@poi-vrc poi-vrc merged commit e59b9a5 into master Mar 13, 2024
11 of 13 checks passed
@poi-vrc poi-vrc deleted the v2-ma-ndmf branch March 13, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant