sample(DBLogger): Add example DBLogger.properties file.

Data/samples/DBLogger/DBLogger.properties

@@ -0,0 +1,28 @@
+#
+# Source parameters:
+#
+# (Mandatory) Directory to scan for .sql files
+#
+DBLogger.dir =
+
+#
+# Destination database parameters:
+#
+# (Mandatory) Database connector (for example sqlite)
+#
+DBLogger.connector =
+
+#
+# (Mandatory) Database connection string (connector specific)
+#
+DBLogger.constring =
+
+#
+# (Optional) Number of workers to insert logs into the database in parallel (default = 2)
+#
+# DBLogger.workers = 2
+
+#
+# (Optional) Create demo SQL messages for testing purposes (default = false)
+#
+# DBLogger.demo = false

Data/samples/DBLogger/src/DBLogger.cpp

@@ -12,10 +12,10 @@
 
 #include "Poco/Data/SQLChannel.h"
 #include "Poco/Data/SQLite/Connector.h"
+#include "Poco/Util/HelpFormatter.h"
 #include "Poco/Util/Option.h"
 #include "Poco/Util/OptionException.h"
 #include "Poco/Util/OptionSet.h"
-#include "Poco/Util/HelpFormatter.h"
 #include "Poco/Util/ServerApplication.h"
 
 #include "SQLLogInserter.h"
@@ -36,14 +36,8 @@ class DBLogger: public ServerApplication
 
 	using WorkSet = std::unordered_set<std::string>;
 
-	DBLogger():
-		_helpRequested(false)
-	{
-	}
-
-	~DBLogger() override
-	{
-	}
+	DBLogger() = default;
+	~DBLogger() override = default;
 
 protected:
 	void initialize(Application& self) override
@@ -79,6 +73,7 @@ class DBLogger: public ServerApplication
 		_inserter.setConnectionString( cfg.getString("DBLogger.constring") );
 
 		_inserter.setNumWorkers( cfg.getUInt64("DBLogger.workers", 2) );
+		_demoMessagesRequested = cfg.getBool("DBLogger.demo", false);
 
 		logger().information("Directory: %s", _inserter.directory());
 		logger().information("Database: %s, %s", _inserter.connector(), _inserter.connectionString());
@@ -87,10 +82,7 @@ class DBLogger: public ServerApplication
 		if (_demoMessagesRequested)
 		{
 			// Only delete and create table when creating demo messages
-			logger().information("Database connector: %s, cs: %s",
-								 _inserter.connector(), _inserter.connectionString());
-			logger().information("Directory: %s", _inserter.directory());
-			logger().information("Number of workers: %z", _inserter.numWorkers());
+			logger().information("Demo messages: Creating new table: %s", _tableName);
 
 			Poco::Data::Session session (_inserter.connector(), _inserter.connectionString());
 
@@ -199,6 +191,7 @@ class DBLogger: public ServerApplication
 			Option("demo", "m", "create demo messages")
 				.required(false)
 				.repeatable(false)
+				.binding("DBLogger.demo")
 				.callback(OptionCallback<DBLogger>(this, &DBLogger::handleCreateDemoMessages)));
 
 	}
@@ -212,7 +205,7 @@ class DBLogger: public ServerApplication
 
 	void handleCreateDemoMessages(const std::string& name, const std::string& value)
 	{
-		_demoMessagesRequested = true;
+		config().setString("DBLogger.demo", "true");
 	}
 	void displayHelp()
 	{
@@ -229,7 +222,11 @@ class DBLogger: public ServerApplication
 		{
 			for (int j = 0; j < 100 && _active; ++j)
 			{
-				Poco::Message msg("SQL Source", Poco::format("%d Informational message", i), Poco::Message::PRIO_INFORMATION);
+				const Poco::Message msg(
+					"SQL Source",
+					Poco::format("%d Informational message", i),
+					Poco::Message::PRIO_INFORMATION
+				);
 				_sqlChannel->log(msg);
 				++i;
 				++_created;

Data/samples/DBLogger/src/SQLLogInserter.cpp

@@ -11,11 +11,9 @@
 
 #include "SQLLogInserter.h"
 
-#include "Poco/Util/Application.h"
-
-#include <iostream>
 #include <filesystem>
 #include <fstream>
+#include <iostream>
 
 using namespace Poco::Data::Keywords;
 
@@ -150,7 +148,7 @@ void SQLLogInserter::processFile(std::string& entry)
 	bool success {false};
 	try
 	{
-		std::ifstream is(entry);
+		const std::ifstream is(entry);
 		std::stringstream buffer;
 		buffer << is.rdbuf();
 		const auto& sql { buffer.str() };
@@ -187,8 +185,11 @@ std::size_t SQLLogInserter::scanDirectory()
 {
 	std::vector<std::string> newEntries;
 	newEntries.reserve(1000);
-	std::filesystem::directory_iterator diriter(_directory, std::filesystem::directory_options::skip_permission_denied);
-	for (auto& entry: diriter)
+	const std::filesystem::directory_iterator diriter(
+		_directory,
+		std::filesystem::directory_options::skip_permission_denied
+	);
+	for (const auto& entry: diriter)
 	{
 		if (!_active)
 		{