Fix for #1775 and #1760

[wuxiaojun514]

Q	A
Bug fix?	[ x]
New feature?	[ ]
New sample?	[ ]
Related issues?	fixes #1775 #1760

What's in this Pull Request?

This pull request is to fix two issues on required field validation issues in Dynamic Form control
Dynamic Form has done huge refactoring on version 3.17. See pull request 1672 for detail

The root cause of issue #1760 is due to the initial value of newValue has been changed from "null" to "undefined". So I modified the related code to "undefined" as well.

Regarding #1775 , now changedValue won't use loaded item's value as initial value. So I added another check to compare with value when there is no new value on this field.

[6gal6ler6]

@wuxiaojun514

Thanks for taking care of this issue!!!

[devspfx]

When will be this fix available? When we will have a new release?

[joelfmrodrigues]

Waiting for #1726

[devspfx]

@joelfmrodrigues any news about this issue? We hope to have a resolution

[martinlingstuyl]

Waiting for #1726

Hi @joelfmrodrigues, why is this PR dependant on the #1726? It seems to be unrelated: editing filenames versus required fields showing a message.

It would be nice if we could ditch the dependency and get this fixed soon. (I've got customers running into this as well...) If I can help with any of this, do let me know!

[joelfmrodrigues]

Hey @martinlingstuyl I will have a look and likely merge this one as the other PR has unresolved conflicts for a long time. I haven't been active for a while for personal reasons (new kid and too much work 😅) but trying to get my head back into this and will try to look into this later today or over the weekend

[martinlingstuyl]

Great to hear @joelfmrodrigues! Yeah, personal reasons enough that can lower your available time in open source. also on my end recently. I know how it goes 😀

Do let me know if I can be of help...

[joelfmrodrigues]

@wuxiaojun514 This is now merged. I'm really sorry for the time it took to merge
Thanks for the great work and clean code change

[joelfmrodrigues]

@6gal6ler6 @devspfx @martinlingstuyl this is now merged, apologies for the delay

[martinlingstuyl]

That's great to hear @joelfmrodrigues! My customer is going to be super excited 😀

What's the release date for 3.20?

[joelfmrodrigues]

@martinlingstuyl no date scheduled yet, but I will start the discussion on this as I can see there are several fixes/improvements already in this beta

[martinlingstuyl]

Maybe I can fix the PR assigned to me first.😊 I'll see if I can make haste there

[martinlingstuyl]

Hi @joelfmrodrigues,

I now see why you related this pr to #1726:

The testform now only works if I include FileLeafRef in the hiddenFields array. If I do not do that, submitting the form fails without an error. (due to the fact that the dynamic form currently cannot render File type Fields.

What I'm now using in TestForm.tsx:

<DynamicForm
          context={this.props.context}
          contentTypeId='0x0120D52000796BC7FCC8B819488729FB2B77B0E799002B2379630DCCB04D883603B763E843D7'
          listId={this.props.context.list.guid.toString()}
          listItemId={this.props.context.itemId}
          hiddenFields={['FileLeafRef']}
          onListItemLoaded={async (listItemData: any) => { // eslint-disable-line @typescript-eslint/no-explicit-any
            console.log(listItemData);
          }} />

FYI

[6gal6ler6]

Will the branch conflicts of #1726 be resolved?

I see that @gruizdev is not responsive on that PR

[joelfmrodrigues]

Hi @joelfmrodrigues,

I now see why you related this pr to #1726:

The testform now only works if I include FileLeafRef in the hiddenFields array. If I do not do that, submitting the form fails without an error. (due to the fact that the dynamic form currently cannot render File type Fields.

What I'm now using in TestForm.tsx:

<DynamicForm
          context={this.props.context}
          contentTypeId='0x0120D52000796BC7FCC8B819488729FB2B77B0E799002B2379630DCCB04D883603B763E843D7'
          listId={this.props.context.list.guid.toString()}
          listItemId={this.props.context.itemId}
          hiddenFields={['FileLeafRef']}
          onListItemLoaded={async (listItemData: any) => { // eslint-disable-line @typescript-eslint/no-explicit-any
            console.log(listItemData);
          }} />

FYI

Ouch, I missed this, thanks for reporting back