-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds contributor quote #6508
Adds contributor quote #6508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make a couple of improvements before we merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's optimize the pictures a bit to display on a website. I like using https://tinypng.com for this. Maybe we should do this with the other images as well. I see one image is a whopping 1MB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good feed. I am spoiled by company founded Azure storage 😁
|
||
<div className='row testimonial'> | ||
<div className='col testimonial-image'> | ||
<img src={require('!!url-loader!../images/testimonials-companies-logo/nanddeep-nachan.png').default} alt='Nanddeep Nachan' /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the documented way of referencing pictures in Docusaurus. This will be important when we introduce versioning in our docs. Let's update the other pictures as well.
<img src={require('!!url-loader!../images/testimonials-companies-logo/nanddeep-nachan.png').default} alt='Nanddeep Nachan' /> | |
<img src={require('@site/docs/images/testimonials-companies-logo/nanddeep-nachan.png').default} alt='Nanddeep Nachan' /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last time I checked this totally did not work 😜. But I will recheck again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it myself during reviewing, and it worked for me 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but did you also try it for the .svg file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I haven't. I would expect it to work the same way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that is also what I expected but I already did that attempt and wrote it here
#6450 (comment)
and at that time it worked for .png files but not for .svg file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Adam-it, where is the SVG file actually? I don't see one on the testimonials page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aa sorry, There was one from Voitanos but I see this was updated by AC 🙂. Problem solved then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll resolve my feedback while merging it @Adam-it.
Merged manually, thanks! |
No description provided.