Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds contributor quote #6508

Closed
wants to merge 2 commits into from
Closed

Adds contributor quote #6508

wants to merge 2 commits into from

Conversation

Adam-it
Copy link
Member

@Adam-it Adam-it commented Nov 28, 2024

No description provided.

@milanholemans milanholemans self-assigned this Dec 18, 2024
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make a couple of improvements before we merge it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's optimize the pictures a bit to display on a website. I like using https://tinypng.com for this. Maybe we should do this with the other images as well. I see one image is a whopping 1MB.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good feed. I am spoiled by company founded Azure storage 😁


<div className='row testimonial'>
<div className='col testimonial-image'>
<img src={require('!!url-loader!../images/testimonials-companies-logo/nanddeep-nachan.png').default} alt='Nanddeep Nachan' />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the documented way of referencing pictures in Docusaurus. This will be important when we introduce versioning in our docs. Let's update the other pictures as well.

Suggested change
<img src={require('!!url-loader!../images/testimonials-companies-logo/nanddeep-nachan.png').default} alt='Nanddeep Nachan' />
<img src={require('@site/docs/images/testimonials-companies-logo/nanddeep-nachan.png').default} alt='Nanddeep Nachan' />

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last time I checked this totally did not work 😜. But I will recheck again

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it myself during reviewing, and it worked for me 😊

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but did you also try it for the .svg file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I haven't. I would expect it to work the same way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that is also what I expected but I already did that attempt and wrote it here
#6450 (comment)
and at that time it worked for .png files but not for .svg file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to look into it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Adam-it, where is the SVG file actually? I don't see one on the testimonials page.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aa sorry, There was one from Voitanos but I see this was updated by AC 🙂. Problem solved then

docs/docs/about/testimonials-quotes.mdx Outdated Show resolved Hide resolved
@milanholemans milanholemans marked this pull request as draft December 18, 2024 23:11
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll resolve my feedback while merging it @Adam-it.

@milanholemans milanholemans marked this pull request as ready for review December 22, 2024 17:22
@milanholemans milanholemans added this to the v10.2 milestone Dec 22, 2024
@milanholemans
Copy link
Contributor

Merged manually, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants