Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds spp autofillcolumn apply command. Closes #6203 #6460

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mkm17
Copy link
Contributor

@mkm17 mkm17 commented Nov 1, 2024

Adds spp autofillcolumn apply command. Closes #6203

Hi, just a few remarks on this command:

I’ve added the columnId and columnTitle parameters to allow selection of the column by either option.

I noticed that retrieving the list instance, like in the getDocumentLibraryInfo function, appears in several places in the solution. Could you advise on where we should store this common code? Is spo.ts the correct file for it?

Similarly, for retrieving a field, should the getColumn function also be placed in spo.ts?

Do you think I should make these updates in this PR, or would it be better to create a separate one?

@mkm17 mkm17 force-pushed the issues/6203_spp_autofillcolumn-apply branch from 2ff3284 to 50c5529 Compare November 1, 2024 21:22
@milanholemans
Copy link
Contributor

Thank you, we'll try to review it ASAP!

@milanholemans
Copy link
Contributor

Sorry for the late reply @mkm17, I totally missed your remark last time.

I noticed that retrieving the list instance, like in the getDocumentLibraryInfo function, appears in several places in the solution. Could you advise on where we should store this common code? Is spo.ts the correct file for it?

Is this something we are using at a lot of other spots? Seems like in your code you are only retrieving the list BaseType. I don't know if we need this in other places?

Similarly, for retrieving a field, should the getColumn function also be placed in spo.ts?

SPO util will be the right place I guess, yes.

Do you think I should make these updates in this PR, or would it be better to create a separate one?

To me, it kind of depends on how many places we'll have to replace code by this util function. If it's just one other command, you can easily add it to this PR. If there are like 5 other commands sharing the same logic, I'd opt for a separate issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New command: m365 spp autofillcolumn apply
2 participants