Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extends 'spo list get' command with support for retrieving any default list in a given site #6447

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Extends 'spo list get' command with support for retrieving any default list in a given site #6447

wants to merge 11 commits into from

Conversation

tmaestrini
Copy link

Closes #5856.

This PR substitutes PR #6445

@tmaestrini tmaestrini changed the title 5856 retrieve default list in site Extends 'spo list get' command with support for retrieving any default list in a given site Oct 22, 2024
@milanholemans
Copy link
Contributor

Thanks, we'll have a look at it ASAP.

@Adam-it Adam-it added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 29, 2024
@Adam-it
Copy link
Member

Adam-it commented Oct 29, 2024

@tmaestrini I added the hacktoberfest-accepted label to this PR which means that this PR will count as done for the Hacktoberfest event. So if you participate in this event it will get you unblocked and it allows us to merge this PR later when we catch up 👍
Thanks for your support and awesome contribution 👏 You Rock 🤩

@tmaestrini
Copy link
Author

@Adam-it Thanks a lot! :) Looking forward to my very first contribution on the M365 cli when this PR gets closed! ;)

@tmaestrini
Copy link
Author

Do you want me to do something on this? Is there anything missing?

@Adam-it
Copy link
Member

Adam-it commented Nov 7, 2024

Do you want me to do something on this? Is there anything missing?

@tmaestrini I don't think there is anything missing. We have a lot of PRs to process but we will try to catch up with this ASAP

@milanholemans milanholemans self-assigned this Dec 8, 2024
milanholemans
milanholemans requested changes Dec 8, 2024
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @tmaestrini, I suggest we make some minor changes.

src/m365/spo/commands/list/list-get.ts Show resolved Hide resolved
src/m365/spo/commands/list/list-get.ts Show resolved Hide resolved
src/m365/spo/commands/list/list-get.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/list/list-get.spec.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/list/list-get.spec.ts Outdated Show resolved Hide resolved
@milanholemans milanholemans marked this pull request as draft December 8, 2024 23:12
Tobias Maestrini added 4 commits December 26, 2024 00:51
@tmaestrini tmaestrini marked this pull request as ready for review December 26, 2024 23:32
@tmaestrini
Copy link
Author

@milanholemans, I guess we're good to go now. Have another review! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milanholemans milanholemans milanholemans requested changes

Assignees

@milanholemans milanholemans

Labels
hacktoberfest-accepted Accept for hacktoberfest, will merge later
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Retrieve default list in site
3 participants
@tmaestrini @milanholemans @Adam-it