Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to bypass shared locks for 'spo file remove'. #6428

Closed
wants to merge 1 commit into from

Conversation

Saurabh7019
Copy link
Contributor

Closes #6313

@Saurabh7019 Saurabh7019 marked this pull request as ready for review October 14, 2024 10:43
@milanholemans
Copy link
Contributor

Thank you @Saurabh7019! We'll try to review it ASAP!

@milanholemans milanholemans self-assigned this Oct 14, 2024
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great! Nice enhancement! Apart from one small remark, nothing to add!

Comment on lines +558 to +560
if (opts.headers &&
opts.headers.accept &&
opts.headers.accept === 'application/json;odata=nometadata') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the check for accept headers. They don't add much value here.

@milanholemans
Copy link
Contributor

Merged manually, thank you for the enhancement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to bypass shared locks for spo file remove
2 participants