Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows case-insensitive column name 'Id' on spo listitem batch remove. #6427

Closed
wants to merge 1 commit into from
Closed

Allows case-insensitive column name 'Id' on spo listitem batch remove. #6427

wants to merge 1 commit into from

Conversation

Saurabh7019
Copy link
Contributor

Closes #6419

@Saurabh7019 Saurabh7019 marked this pull request as ready for review October 12, 2024 19:16
@milanholemans
Copy link
Contributor

Thank you, we'll try to have a look at it ASAP!

@Adam-it Adam-it added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 29, 2024
@Adam-it
Copy link
Member

Adam-it commented Oct 29, 2024

@Saurabh7019 I added the hacktoberfest-accepted label to this PR which means that this PR will count as done for the Hacktoberfest event. So if you participate in this event it will get you unblocked and it allows us to merge this PR later when we catch up 👍
Thanks for your support and awesome contribution 👏 You Rock 🤩

@milanholemans milanholemans self-assigned this Nov 17, 2024
milanholemans
milanholemans requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice enhancement @Saurabh7019, I think we should make use of some existing validators for this.
Also, could you add an additional test where we explicitly test for an ID column with different casing?

src/m365/spo/commands/listitem/listitem-batch-remove.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/listitem/listitem-batch-remove.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/listitem/listitem-batch-remove.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/listitem/listitem-batch-remove.ts Outdated Show resolved Hide resolved
@milanholemans milanholemans marked this pull request as draft November 19, 2024 23:23
@Saurabh7019 Saurabh7019 marked this pull request as ready for review November 20, 2024 11:46
milanholemans
milanholemans approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one tiny enhancement, it looks good to me.

src/m365/spo/commands/listitem/listitem-batch-remove.ts Outdated Show resolved Hide resolved
@milanholemans
Copy link
Contributor

Merged manually, thanks for the convenient enhancement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milanholemans milanholemans milanholemans approved these changes

Assignees

@milanholemans milanholemans

Labels
hacktoberfest-accepted Accept for hacktoberfest, will merge later pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow case-insensitive column name Id on spo listitem batch remove
3 participants
@Saurabh7019 @milanholemans @Adam-it