Adds command spp model remove. Closes #6118
#6410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, well try to review it ASAP! |
mkm17
force-pushed
the
issues/6118_spp_model_remove
branch
from
5afaf7c to
9a84d0e
Compare
milanholemans
requested changes
Oct 17, 2024
mkm17
force-pushed
the
issues/6118_spp_model_remove
branch
from
9a84d0e to
53f4c24
Compare
Adam-it
added
the
hacktoberfest-accepted
|
@mkm17 I added the |
milanholemans
requested changes
Nov 10, 2024
mkm17
force-pushed
the
issues/6118_spp_model_remove
branch
from
53f4c24 to
e4e531d
Compare
|
Hi @milanholemans, ok thank you for the review. You are right, I now understand the odata.null case. |
milanholemans
requested changes
Nov 19, 2024
mkm17
force-pushed
the
issues/6118_spp_model_remove
branch
from
e4e531d to
3e2c005
Compare
|
@milanholemans I hope the changes to the tests are fine. I've included the same check for the |
milanholemans
approved these changes
Nov 24, 2024
| option: '-t, --title [title]' | ||
| }, | ||
| { | ||
| option: '-f --force' |
There was a problem hiding this comment.
Suggested change
| option: '-f --force' | |
| option: '-f, --force' |
| public async commandAction(logger: Logger, args: CommandArgs): Promise<void> { | ||
| try { | ||
| if (!args.options.force) { | ||
| const confirmationResult = await cli.promptForConfirmation({ message: `Are you sure you want to remove model '${args.options.title ? args.options.title : args.options.id}'?` }); |
There was a problem hiding this comment.
Suggested change
| const confirmationResult = await cli.promptForConfirmation({ message: `Are you sure you want to remove model '${args.options.title ? args.options.title : args.options.id}'?` }); | |
| const confirmationResult = await cli.promptForConfirmation({ message: `Are you sure you want to remove model '${args.options.title ?? args.options.id}'?` }); |
| assert(stubDelete.calledOnce); | ||
| }); | ||
|
|
||
| it('deletes model by title with .classifier suffic', async () => { |
There was a problem hiding this comment.
Suggested change
| it('deletes model by title with .classifier suffic', async () => { | |
| it('deletes model by title with .classifier suffix', async () => { |
| it('deletes model by title with .classifier suffic', async () => { | ||
| const stubDelete = sinon.stub(request, 'delete').callsFake(async (opts) => { | ||
| if (opts.url === `https://contoso.sharepoint.com/sites/portal/_api/machinelearning/models/getbytitle('modelname.classifier')`) { | ||
| return ''; |
There was a problem hiding this comment.
Suggested change
| return ''; | |
| return; |
| it('deletes model by title', async () => { | ||
| const stubDelete = sinon.stub(request, 'delete').callsFake(async (opts) => { | ||
| if (opts.url === `https://contoso.sharepoint.com/sites/portal/_api/machinelearning/models/getbytitle('modelname.classifier')`) { | ||
| return ''; |
There was a problem hiding this comment.
Suggested change
| return ''; | |
| return; |
|
Merged manually, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds command
spp model remove. Closes #6118