Adds spp model get command Closes #6105

[mkm17]

Adds spp model get command Closes #6105

[milanholemans]

Thank you, well try to review it ASAP!

[mkm17]

I have converted it to draft, as there are some conflicts to be resolved.

[Adam-it]

@mkm17 I added the hacktoberfest-accepted label to this PR which means that this PR will count as done for the Hacktoberfest event. So if you participate in this event it will get you unblocked and it allows us to merge this PR later when we catch up 👍
Thanks for your support and awesome contribution 👏 You Rock 🤩

[milanholemans]

Nice start @mkm17, let's change a few things before we proceed.

[mkm17]

@milanholemans thank you again for the review. I believe I have addressed all the suggested changes. I have one question regarding the tests: I updated it to assert.strictEqual(JSON.stringify(loggerLogSpy.lastCall.args[0]), JSON.stringify(modelResult)); instead of the previous approach. Is that ok?

[milanholemans]

@milanholemans thank you again for the review. I believe I have addressed all the suggested changes. I have one question regarding the tests: I updated it to assert.strictEqual(JSON.stringify(loggerLogSpy.lastCall.args[0]), JSON.stringify(modelResult)); instead of the previous approach. Is that ok?

Is there a reason why we stringify everything instead of using assert.deepStrictEqual?

[mkm17]

@milanholemans I saw this method somewhere in the code, but definitely it is a much better idea. Thank you.

[milanholemans]

It's looking good, we're almost there.

[mkm17]

@milanholemans Thank you for the review. The changes have been applied to the new version.

[milanholemans]

Apart from one tiny enhancement, it looks good to me.

[milanholemans]

This response is looking gigantic right now. Let's try to trim it down a bit by:

• For arrays, let's show only 1 object in the array.
• Right now, we have multiple fields in the model like: address, discount percentage, date of change, ... Let's show only one of those.

[mkm17]

@milanholemans ok, it is done now, the response should be shorter :)

[milanholemans]

Merged manually, thanks!