Added internalName option for spo field commands #6379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, we'll try to review it ASAP! |
MathijsVerbeeck
requested changes
Nov 29, 2024
|
|
||
| it('should call the correct GET url when field internalName and list url specified', async () => { | ||
| const getStub = sinon.stub(request, 'get').callsFake(async (opts) => { | ||
| if ((opts.url as string).indexOf(`/_api/web/lists`) > -1) { |
There was a problem hiding this comment.
Could we please use full URL's instead of using indexOf please? Please do this for all your tests
| const getStub = sinon.stub(request, 'get').callsFake(async (opts) => { | ||
| if ((opts.url as string).indexOf(`/_api/web/lists`) > -1) { | ||
| return { | ||
| "Id": "03e45e84-1992-4d42-9116-26f756012634" |
There was a problem hiding this comment.
Please let's use single quotes
| @@ -320,6 +320,51 @@ describe(commands.FIELD_GET, () => { | |||
| assert.strictEqual(getStub.lastCall.args[0].url, 'https://contoso.sharepoint.com/sites/portal/_api/web/lists(guid\'03e45e84-1992-4d42-9116-26f756012634\')/fields/getbyinternalnameortitle(\'Title\')'); | |||
| }); | |||
|
|
|||
| it('should call the correct GET url when field internalName and list title specified (verbose)', async () => { | |||
| const getStub = sinon.stub(request, 'get').callsFake(async (opts) => { | |||
| if ((opts.url as string).indexOf(`/_api/web/lists`) > -1) { | |||
There was a problem hiding this comment.
Same here, let's use full url's
| @@ -117,6 +122,9 @@ class SpoFieldGetCommand extends SpoCommand { | |||
| if (args.options.id) { | |||
| fieldRestUrl = `/getbyid('${formatting.encodeQueryParameter(args.options.id)}')`; | |||
| } | |||
| else if (args.options.internalName) { | |||
There was a problem hiding this comment.
Could we not do something like:
Suggested change
| else if (args.options.internalName) { | |
| else { | |
| fieldRestUrl = `/getbyinternalnameortitle('${formatting.encodeQueryParameter(args.options.internalName || args.options.title)}')`; | |
| } |
| @@ -454,6 +466,51 @@ describe(commands.FIELD_REMOVE, () => { | |||
| assert.strictEqual(getStub.lastCall.args[0].url, 'https://contoso.sharepoint.com/sites/portal/_api/web/lists(guid\'03e45e84-1992-4d42-9116-26f756012634\')/fields/getbyinternalnameortitle(\'Title\')'); | |||
| }); | |||
|
|
|||
| it('calls the correct get url when field internalName and list title specified (verbose)', async () => { | |||
| const getStub = sinon.stub(request, 'post').callsFake(async (opts) => { | |||
| if ((opts.url as string).indexOf(`/_api/web/lists`) > -1) { | |||
There was a problem hiding this comment.
Same here, let's use full URLs
| @@ -112,6 +112,44 @@ describe(commands.FIELD_SET, () => { | |||
| assert(loggerLogSpy.notCalled); | |||
| }); | |||
|
|
|||
| it('updates site column specified by internalName', async () => { | |||
| sinon.stub(request, 'post').callsFake(async (opts) => { | |||
| if ((opts.url as string).indexOf(`/_vti_bin/client.svc/ProcessQuery`) > -1) { | |||
There was a problem hiding this comment.
Let's use full urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6249
In this PR, i have added
internalNameoption to below commandsspo field getspo field setspo field remove