New command: viva engage community set. Closes #6279 #6283
Conversation
|
Thanks, we'll try to review it ASAP! |
MartinM85
force-pushed
the
feature/6279-viva-engage-community-set
branch
from
206e13a to
48ce8ca
Compare
MartinM85
force-pushed
the
feature/6279-viva-engage-community-set
branch
from
de78bb5 to
539e643
Compare
There was a problem hiding this comment.
Hey @MartinM85, there are a few PRs open today related to viva engage community. In one of those, @martinlingstuyl suggested some changes to the util to improve performance and make it more dynamic. Ref: #6388 (comment)
It might be worth considering those changes here too since you're working with the same util in a similar context.
|
@Jwaegebaert ok, I will update the util based on |
|
Great! I'm not entirely sure this is the best approach yet, so it could be subjected to change 🤞 |
@MartinM85 did you already had a chance to update the utils? I am not 100% sure if this is ready for a recheck? |
MartinM85
force-pushed
the
feature/6279-viva-engage-community-set
branch
from
539e643 to
756450f
Compare
|
Hi @Adam-it, I was waiting to avoid update vivaEngage utils multiple times. Update right now, so it's ready for review |
MartinM85
force-pushed
the
feature/6279-viva-engage-community-set
branch
from
8d94a32 to
d2c8853
Compare
|
Hi @Adam-it, do you plan to review this PR in the coming days/weeks? In the meantime, other commands related to the viva engage community are merged, so I'm just rebasing (this and #6286). It seems to me better to wait until the other commands with higher priority are merged. Now it's useless effort for me. |
TBH I was going to to that last time but I didn't manage. Today we started internal code freeze till upcoming major release which will be at the end of this month and during this time we only may merge pr-major pr-priority and docs PRs. This means this PR may proceed no sooner than at the beginning of November |
|
ready to merge 🚀 |
|
Merged manually. Thank you for your awesome work! You Rock !🤩 |
Closes #6279