All entra m365group commands should accept displayName option

[MartinM85]

Closes #6147

[milanholemans]

Thank you @MartinM85 we'll try to review it ASAP

[milanholemans]

Hi @MartinM85, could you resolve the merge conflicts by rebasing with the latest main, please?

[MartinM85]

@milanholemans Two commands where extended with groupName option. What's the correct option name? Still groupDisplayName?

[milanholemans]

We've renamed a bunch of commands from groupDisplayName to groupName #5616
So groupName is the option name we should use.

[Adam-it]

@MartinM85 may I kindly ask you to rebase the PR again before I may proceed with the review.
@milanholemans if we in this PR we are changing the groupDisplayName to groupName like in docs/docs/cmd/entra/m365group/m365group-conversation-post-list.mdx isn't this breaking change and this should be a pr-major as we may only do that now with the v10 release?

[milanholemans]

@MartinM85 may I kindly ask you to rebase the PR again before I may proceed with the review. @milanholemans if we in this PR we are changing the groupDisplayName to groupName like in docs/docs/cmd/entra/m365group/m365group-conversation-post-list.mdx isn't this breaking change and this should be a pr-major as we may only do that now with the v10 release?

That wasn't really the purpose of the issue, but the commands should be aligned indeed. You are right.

[MartinM85]

@Adam-it Hope I've rebased everything correctly

[Adam-it]

That wasn't really the purpose of the issue, but the commands should be aligned indeed. You are right.

Ok I will add pr-major label to this PR since now it is a breaking change

[Adam-it]

@MartinM85 Awesome work so far 👏👏👏👏
Before we proceed lets recheck the naming. TBH I do not quite feel that in some places/commands we refer to the same option as name and in other as displayName . I would try to align this
tagging @milanholemans to double check if maybe I missed anything from the initial issue

[Adam-it]

@MartinM85 Awesome work 👏👏👏👏
I added just one small comment
and also when testing I noticed that the command m365 entra m365group teamify will not work if I use the newly added displayName option.

Would you like to give it a double check?

[MartinM85]

Hi @Adam-it, I had a typo in dispalyName.

[Adam-it]

Hi @Adam-it, I had a typo in dispalyName.

Thanks for the quick turn around. I will try to make more reviews this week and for sure will retake this one as well

[Adam-it]

Perfect 🤩

[Adam-it]

Read to merge 🚀

[Adam-it]

Merged manually. Thank you for your awesome work! You Rock !🤩
@MartinM85 I noticed that you have been doing a looooot of awesome stuff in CLI repo 🚀. I was wondering if you would like to present some of your work, what you added to the CLI, or how you go about it, or why you do it, or how you use CLI.. etc to the community on one of the PnP Community calls?

[MartinM85]

@Adam-it I can try to present some of my work on the PnP Community calls, but I can't say now what exactly. :)

[Adam-it]

@Adam-it I can try to present some of my work on the PnP Community calls, but I can't say now what exactly. :)

that's awesome to hear 🤩. You may more than one demo if you want 😉. There are plenty of awesome stuff you did that may be presented 👏
May I kindly ask you to fill out the form so that we may set a demo spot for you
https://forms.office.com/pages/responsepage.aspx?id=v4j5cvGGr0GRqy180BHbR8ke1rGfE-VNsUHrnMWCrL5UNjhIVEc4VERQUDNYOTM4MDdKN1ZLWFVBMSQlQCN0PWcu