Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds command 'tenant people profilecardproperty add'. Closes #5617 #5624

Closed
wants to merge 7 commits into from
Closed

Adds command 'tenant people profilecardproperty add'. Closes #5617 #5624

wants to merge 7 commits into from

Conversation

martinlingstuyl
Copy link
Contributor

Closes #5617

Adds command 'tenant people profilecardproperty add'.

@martinlingstuyl martinlingstuyl added the pr-priority Process this PR asap label Nov 2, 2023
@Jwaegebaert Jwaegebaert self-assigned this Nov 2, 2023
@martinlingstuyl
Copy link
Contributor Author

Hi @Jwaegebaert, I'm currently updating the code. Will push in a few minutes

@martinlingstuyl
Copy link
Contributor Author

There it is @Jwaegebaert...

@Jwaegebaert
Copy link
Contributor

No problem, one pointer I noticed. I don't have the required scope added yet to my app reg but the error returned is a bit vague:
image

Could be worth looking into.

Jwaegebaert
Jwaegebaert requested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@Jwaegebaert Jwaegebaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @martinlingstuyl, I've left a few pointers you can take a look at.

src/m365/tenant/commands/people/profileCardProperties.ts Outdated Show resolved Hide resolved
docs/docs/cmd/tenant/people/people-profilecardproperty-add.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/tenant/people/people-profilecardproperty-add.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/tenant/people/people-profilecardproperty-add.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/tenant/people/people-profilecardproperty-add.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/tenant/people/people-profilecardproperty-add.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/tenant/people/people-profilecardproperty-add.mdx Outdated Show resolved Hide resolved
src/m365/tenant/commands/people/people-profilecardproperty-add.ts Outdated Show resolved Hide resolved
src/m365/tenant/commands/people/people-profilecardproperty-add.ts Outdated Show resolved Hide resolved
src/m365/tenant/commands/people/people-profilecardproperty-add.ts Outdated Show resolved Hide resolved
@martinlingstuyl
Copy link
Contributor Author

No problem, one pointer I noticed. I don't have the required scope added yet to my app reg but the error returned is a bit vague: image

Could be worth looking into.

That's probably because the error object coming in from the Graph has an empty message. :(
image
not sure how to solve this here... The MS Graph team should make this more descriptive, or we should implement checks based on the HTTP status code.. But that seems a change that would impact a lot of other code.

@waldekmastykarz
Copy link
Member

No problem, one pointer I noticed. I don't have the required scope added yet to my app reg but the error returned is a bit vague: image

Could be worth looking into.

That's probably because the error object coming in from the Graph has an empty message. :(

image

not sure how to solve this here... The MS Graph team should make this more descriptive, or we should implement checks based on the HTTP status code.. But that seems a change that would impact a lot of other code.

Let's log it as a separate issue

@martinlingstuyl martinlingstuyl mentioned this pull request Nov 3, 2023
Open
Jwaegebaert
Jwaegebaert approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@Jwaegebaert Jwaegebaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @martinlingstuyl, found a few little points of attention but resolved them myself during the merging process.

src/m365/tenant/commands/people/people-profilecardproperty-add.ts Outdated Show resolved Hide resolved
docs/docs/cmd/tenant/people/people-profilecardproperty-add.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/tenant/people/people-profilecardproperty-add.mdx Outdated Show resolved Hide resolved
@Adam-it Adam-it self-assigned this Nov 4, 2023
Adam-it
Adam-it reviewed Nov 4, 2023
View reviewed changes
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally ✅
2 tiny comments 👍

src/m365/tenant/commands/people/people-profilecardproperty-add.ts Show resolved Hide resolved
src/m365/tenant/commands/people/people-profilecardproperty-add.ts Show resolved Hide resolved
@Adam-it
Copy link
Member

Adam-it commented Nov 4, 2023

@Jwaegebaert LGTM 👍 I added 2 little comments from my side. Other then that I thing we are ready to go 🚀

@Jwaegebaert Jwaegebaert closed this Nov 4, 2023
@martinlingstuyl martinlingstuyl deleted the profileproperty-add branch November 5, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adam-it Adam-it Adam-it left review comments

@Jwaegebaert Jwaegebaert Jwaegebaert approved these changes

Assignees

@Jwaegebaert Jwaegebaert

@Adam-it Adam-it

Labels
pr-merged pr-priority Process this PR asap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adds command to add profile card properties
4 participants
@martinlingstuyl @Jwaegebaert @waldekmastykarz @Adam-it