Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates spfx workflow add command. Closes #5566 #5584

Closed
wants to merge 3 commits into from

Conversation

Adam-it
Copy link
Member

@Adam-it Adam-it commented Oct 21, 2023

🔗 Linked Issue

Closes #5566

📸 Result

image

@martinlingstuyl martinlingstuyl self-assigned this Nov 7, 2023
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small comments @Adam-it. I can merge this tomorrow

@Adam-it
Copy link
Member Author

Adam-it commented Nov 7, 2023

2 small comments @Adam-it. I can merge this tomorrow

Awesome, I will look at them today and resolve what is needed

@martinlingstuyl
Copy link
Contributor

Nice, let me try that out and hopefully merge tonight.

Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works fine! Ship it! 🚀

@martinlingstuyl
Copy link
Contributor

Merged manually, fan-tas-tic work, you rock 🚀

@Adam-it Adam-it deleted the update-spfx-gh-workflow-command branch November 11, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI/CD pipeline definition of spfx project github workflow add
2 participants