Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move wiki page about codespaces and dev container into normal docs. Closes #5206 #5581

Closed
wants to merge 2 commits into from

Conversation

Aaron-Junker
Copy link
Contributor

Closes #5206

I basically just copy-pasted the wiki page here, so the wiki page can be deleted.

@milanholemans
Copy link
Contributor

Thank you @Aaron-Junker, we'll try to review it ASAP!

@Adam-it Adam-it self-assigned this Oct 28, 2023
@Adam-it
Copy link
Member

Adam-it commented Oct 28, 2023

@Aaron-Junker actually before we proceed we need to understand why building the docs file on the pipeline check.
did you maybe manage to build the docs locally without failure?
It seems the error we are getting is

Error: Docs markdown link couldn't be resolved: (./github-codespaces-and-devcontainer.mdx) in "/home/runner/work/cli-microsoft365/cli-microsoft365/docs/docs/contribute/new-command/build-command-logic.mdx" for version current
Error:  Client bundle compiled with errors therefore further build is impossible.
    at Array.forEach (<anonymous>)

@Adam-it Adam-it marked this pull request as draft October 28, 2023 19:48
@Aaron-Junker
Copy link
Contributor Author

@Aaron-Junker actually before we proceed we need to understand why building the docs file on the pipeline check. did you maybe manage to build the docs locally without failure? It seems the error we are getting is

Error: Docs markdown link couldn't be resolved: (./github-codespaces-and-devcontainer.mdx) in "/home/runner/work/cli-microsoft365/cli-microsoft365/docs/docs/contribute/new-command/build-command-logic.mdx" for version current
Error:  Client bundle compiled with errors therefore further build is impossible.
    at Array.forEach (<anonymous>)

It works for me locally, but my recent commit should fix this.

@Aaron-Junker Aaron-Junker marked this pull request as ready for review October 28, 2023 20:01
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add. Awesome work 👏

@Adam-it
Copy link
Member

Adam-it commented Nov 5, 2023

ready to merge 🚀

@Adam-it Adam-it added pr-merged hacktoberfest-accepted Accept for hacktoberfest, will merge later labels Nov 5, 2023
@Adam-it
Copy link
Member

Adam-it commented Nov 5, 2023

merged manually. Thank you for your awesome work👏
You Rock 🤩

@Adam-it Adam-it closed this Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs hacktoberfest-accepted Accept for hacktoberfest, will merge later pr-merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend contribution guidance with remote development
3 participants