Move Yammer commands to Viva Engage. Closes #5573 #5580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @Aaron-Junker |
waldekmastykarz
requested changes
Oct 29, 2023
There was a problem hiding this comment.
Hey @Aaron-Junker, I noticed a breaking change. Let's fix it before we continue the review
docs/docs/cmd/cli/cli-consent.mdx
Outdated
| @@ -16,7 +16,7 @@ m365 cli consent [options] | |||
|
|
|||
| ```md definition-list | |||
| `-s, --service <service>` | |||
| : Service for which to consent permissions. Allowed values: `yammer` | |||
| : Service for which to consent permissions. Allowed values: `"viva engage"` | |||
There was a problem hiding this comment.
This is a breaking change that we can't introduce in a minor version. I suggest that for the time being we allow both values.
|
@waldekmastykarz I added the option for yammer back in. |
|
Hey @Aaron-Junker, it seems some of the build checks are failing. Could you please have a look before we proceed with the review? |
|
Closing due to lack of response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5573