-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds new script sample 'lists-teams-decluttering' #5575
Conversation
@tmaestrini thanks for opening the PR. We will review it ASAP. |
Thanks, @Adam-it. No, it's only a new basic sample that I wrote. It is based on practical needs. |
docs/docs/sample-scripts/teams/list-teams-decluttering/index.mdx
Outdated
Show resolved
Hide resolved
@milanholemans does my changes fit? Or do you want me to fix anything else? |
Looks good at first sight @tmaestrini 👍 |
Do you want me to do sth else, @Adam-it ? |
Hi, rather not 😉. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmaestrini awesome work 👏.
I love the sample 😍
Lets work on a couple of details around it before we merge 👍
docs/docs/sample-scripts/teams/list-teams-decluttering/assets/preview.png
Outdated
Show resolved
Hide resolved
docs/docs/sample-scripts/teams/list-teams-decluttering/index.mdx
Outdated
Show resolved
Hide resolved
docs/docs/sample-scripts/teams/list-teams-decluttering/sample.json
Outdated
Show resolved
Hide resolved
@Adam-it Thanks for the feedback! 🙏 |
Thanks for the quick turn around. I will give it a check ASAP. What do you see lacking in the script sample? Maybe we could add this to this PR along the way 🙂 |
Dear @Adam-it, thank you – really appreciated! The lacking in the template script is a minor thing; it concerns the indentation starting from line 104 to 106 and 110 to 112. |
I see. |
@tmaestrini if I understood you correctly you are ready for another round right? I marked this PR as 'ready to review' and planning to do so in the upcoming weekend 👍 |
Hey @Adam-it! No need anymore, @milanholemans fixed it in his commit: d781816 |
Looks like someone was monitoring our conversation 😅. Cool, we have it sorted out. I will try to process this PR during the weekend 👍 |
I was aware of this issue since my last PR with the update of the syntax was merged. However, I wasn't able to update it until a few days ago |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 👏
Ready to merge 🚀 |
Thank you, @Adam-it! 🙌 the merge will be done by your team, right? So my work is done "for now"? |
yep. I am doing it now together with other PRs. Should be live in 10-20 min |
merged manually. Thank you for your awesome work👏 |
No description provided.