-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the Spec checklist to the docs #5555
Added the Spec checklist to the docs #5555
Conversation
Is it merged |
Hi @SanidhayaAgarwal like we agreed in the issue, could you add the content to the docs instead of the Also, you shouldn't modify too much to the sidebars.js. The only thing that you'll have to do is add the new page you've created over there. |
check once |
do i have to add to all the files or create a separate file |
Hi @milanholemans now i have made all the changes as said by you and modified the sidebar.js. Please check and merge |
Hi @SanidhayaAgarwal, seems like your file is empty. When you look at the changed files of this PR, you'll see that you've added a file with no content and changed the entire sidebars.js` file. In this PR you should only:
cli-microsoft365/docs/src/config/sidebars.js Lines 4211 to 4266 in 8b56e1d
|
Hey actually i have added a new file and made the changes in that portion itself in the sidebar. Ok i'll creat a new PR |
🚀 Contribution to pnp/cli-microsoft365: Adding a Specification Checklist Document 🚀
Dear Maintainers and Contributors,
I am thrilled to submit this pull request, which introduces a valuable addition to our project's documentation. This enhancement enhances our collaborative development process by providing a detailed "Specification Checklist" document under the "Contributing" section.
📝 What's New?
✨ Specification Checklist: The heart of this contribution is the meticulously crafted "Specification Checklist" document. It defines comprehensive specifications for both new commands and enhancements in the pnp/cli-microsoft365 project. This checklist will serve as a valuable resource to ensure consistency, quality, and adherence to best practices in our development efforts.
🚀 Why It Matters
🙌 Your Feedback Matters!
We encourage everyone to review the new "Specification Checklist" document and provide feedback. Your insights and suggestions are crucial in refining our development process further.
📚 How to Access
You can find the "Specification Checklist" document under the "Contributing" section in the left navigation sidebar of our documentation.
💪 Contributing to Our Community
We believe that an active and engaged community is the backbone of any open-source project. We welcome all contributors, regardless of experience level, and we appreciate your dedication to making this project even better!
Thank you for your time and consideration. Let's continue to build an outstanding CLI tool together.
Cheers to open source and collaboration! 🌟
Best Regards,
Sanidhaya Agarwal