Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli doctor: show scopes by resource #5520

Closed
wants to merge 2 commits into from
Closed

cli doctor: show scopes by resource #5520

wants to merge 2 commits into from

Conversation

dojcsakj
Copy link
Contributor

Closes #5487

@Jwaegebaert
Copy link
Contributor

Thanks for your PR @dojcsakj. We'll try to review it ASAP!

@martinlingstuyl martinlingstuyl self-assigned this Oct 12, 2023
martinlingstuyl
martinlingstuyl reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dojcsakj,
This looks very nice! Also great to see you use the Map<> construct. I've seen it before but never got around to using it. Looks great.

I've only just got a look at the code. I'll need to check out if it actually works as nicely as it looks. Will probably do that tomorrow.

src/m365/cli/commands/cli-doctor.ts Show resolved Hide resolved
martinlingstuyl
martinlingstuyl approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'll merge it sometime soon. 👏

@martinlingstuyl
Copy link
Contributor

Merged manually, thanks 👏

@martinlingstuyl martinlingstuyl added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 25, 2023
@martinlingstuyl
Copy link
Contributor

If you want I can reference you in the attribution posts on Linked IN and X. Please give us your handles if you like that.

@dojcsakj
Copy link
Contributor Author

If you want I can reference you in the attribution posts on Linked IN and X. Please give us your handles if you like that.

I don't use Twitter. I'm janos-dojcsak on LinkedIn.

Thank you, I appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milanholemans milanholemans milanholemans left review comments

@martinlingstuyl martinlingstuyl martinlingstuyl approved these changes

Assignees

@martinlingstuyl martinlingstuyl

Labels
hacktoberfest-accepted Accept for hacktoberfest, will merge later pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Listing scopes using cli doctor
4 participants
@dojcsakj @Jwaegebaert @martinlingstuyl @milanholemans