Extend 'team user app remove' command with --userName (UPN) . Closes #5446 #5457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @reshmee011! Seems like the pipeline fails, could you have a look please? |
|
@milanholemans: I will look into resolving the failures. Hope all is well with you. |
waldekmastykarz
requested changes
Oct 8, 2023
There was a problem hiding this comment.
Hey @reshmee011, it seems that we could simplify the code and speed up its execution. Let's adjust it before we merge it, k?
waldekmastykarz
added
hacktoberfest-accepted
waldekmastykarz
approved these changes
Nov 9, 2023
| @@ -13,6 +14,7 @@ interface CommandArgs { | |||
| interface Options extends GlobalOptions { | |||
| id: string; | |||
| userId: string; | |||
| userName: string; | |||
There was a problem hiding this comment.
Since the user can specify either userName or userId both should be marked as optional
| const endpoint: string = `${this.resource}/v1.0`; | ||
|
|
||
| const requestOptions: CliRequestOptions = { | ||
| url: `${endpoint}/users/${args.options.userId}/teamwork/installedApps/${args.options.id}`, | ||
| url: `${endpoint}/users/${formatting.encodeQueryParameter(userId)}/teamwork/installedApps/${args.options.id}`, |
|
Merged manually. Thank you! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend 'team user app remove' command with --userName (UPN) . Closes #5446