Upgrade ascent build system and use [email protected] on CI platforms
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If Getting the functionality of a pipeline that can rebuilt is more important first so we can iterate quicker. If you want to try and work with GitLab syntax and write some pipelines for ORNL you can follow the example in |
|
Okay, I'll take a look at the gitlab pipeline to build the modules. |
|
@rothpc and @nkoukpaizan not sure why but unzip isn't being found on the path in spack... This doesn't seem to be an issue for all packages, just cub? Latest `MY_CLUSTER=ascent ./buildsystem/spack/install-compute.sh` :Seems like as well there are some weird system issues happening here... Will have to investigate further |
|
It looks like unzip is not found on the compute nodes. |
|
Spack also complains about autoheader not being found during the coinhsl build. A diff between |
Hmm well I am not quite sure I understand the path forward. Should I be then just installing everything in the |
|
I think building on the batch node should be fine, even though we really should be using compute node instances. Would there be an issue with just doing spack builds in the nobatch queue from ORNL's perspective in CI? |
|
It appears the ascent compute nodes don't have all the same RPMs installed as on the login node(s). I see at least two paths forward:
|
|
@rothpc and @nkoukpaizan wolf is down today, but I was able to get a working ExaGO build last night working around quite a few different bugs. Unzip was configurable through a module. Autoheader was another module. Difficult one was Other bug is that when It's possible that using the correct HTTP proxy configuration means we don't need a source mirror configured, so I want to try that out briefly. Apart from that, only remaining step is to put pipelines in place. Thanks for all the help! |
cameronrutherford
force-pushed
the
nicholson/upgrade-ascent-buildsystem
branch
from
d678de8
to
4974e9b
Compare
|
For some reason there was a glibc issue compiling exago with PETSc using gcc 10.2.0 and cuda 11.4 on the system. I tried to instead build with gcc 11.2.0 and a spack built cuda 11.8 to see if that gives us any more luck (since just 11.2 wouldn't work as cuda 11.4 is incompatible with this compiler). |
|
@nkoukpaizan have you seen the error in this pipeline before? https://code.ornl.gov/ecpcitest/exasgd/exago/-/jobs/2070906 As far as I can tell I rebuilt all the PETSc dependencies with the latest compiler, so not sure where this issue is coming from. Maybe I broke something you had already fixed? If you push to the branch, try out the auto rebuild by adding I am likely thinking my mix of external packages is causing issues, but perhaps this is actually a bug with the newest PETSc version? |
cameronrutherford
force-pushed
the
nicholson/upgrade-ascent-buildsystem
branch
from
05319c3
to
de283f0
Compare
…d] [newell-rebuild] [incline-rebuild]
cameronrutherford
force-pushed
the
nicholson/upgrade-ascent-buildsystem
branch
from
741ce9a
to
1516a74
Compare
|
I removed the change for compatibility with |
|
CI passing on Newell and Incline is a good sign. Will have to wait for Ascent to re-build Python to verify that is fixed, but things are looking good. This certainly clarifies that |
|
Ascent test is running - if that passes (along with passing status indications from other platforms, I think we are ready to merge! |
This was referenced Oct 12, 2023
jaelynlitz
approved these changes
Oct 12, 2023
3 tasks
bjpalmer
pushed a commit
that referenced
this pull request
Oct 16, 2023
* Boilerplate scripts to install modules on Ascent via submodule Spack * Fix '--nnodes'-->'-nodes' on Ascent * Improve Ascent env.sh * [email protected] on Ascent * Apply pre-commmit fixes * Relax constraints on exago dependencies on Ascent and build ~python * concretizer: reuse was causing several packages to be duplicated in the environment. Require clean concretizations on Ascent. * Minor module update on Ascent * Add LAPACK_LIBRARIES to Ascent base script. CMAKE was picking up python's openblas otherwise. * Error with unzip. * Apply pre-commmit fixes * Add working build on ascent. * Add working gcc11.2.0 spack spec. * Add Ascent Spack pipeline. [ascent-rebuild] * Update gcc version to 11.2.0 in base.sh [skip-ci] * Fix stages of Ascent pipeline [ascent-rebuild] * Add working ascent spack build. * Add hiop@develop force rebuild to PNNL CI [ascent-rebuild] [newell-rebuild] [deception-rebuild] [incline-rebuild]. * Update Ascent spack built tcl modules * Only test ascent on tcl module update [ci-skip] * Update base.sh to disable python on ascent [skip ci] * Remove LAPACK_LIBRARIES spec [ascent-test] * Update ascent.gitlab-ci.yml to fix needs/dependencies [ascent-test] * Update deception spack built tcl modules - [deception-test] * Try again with Python, but have Spack build it instead of using the external module [ascent-rebuild] * Force python rebuild on ascent and use [email protected] on incline [ascent-rebuild] [newell-rebuild] [incline-rebuild] * Pin [email protected] on all CI platforms [decetpion-rebuild] [ascent-rebuild] [newell-rebuild] [incline-rebuild] * Fix false positive/negative in Ascent pipelines [deception-rebuild] [ascent-test] * Update incline spack built tcl modules - [incline-test] * Update newell spack built tcl modules - [newell-test] * Fix HiOp spec on Ascent [ascent-rebuild]. * Update deception spack built tcl modules - [deception-test] * Update CPU Spack build with issue for each failing build [ci skip] * Update Ascent spack built tcl modules [ascent-test] * Add 1.0.0 dep into CHANGELOG. * Add ascent-skip to CI to get tests passing [ascent-test] --------- Co-authored-by: nkoukpaizan <[email protected]> Co-authored-by: Cameron Rutherford <[email protected]> Co-authored-by: cameronrutherford <[email protected]> Co-authored-by: spack-auto-module <[email protected]>
cameronrutherford
added a commit
that referenced
this pull request
Oct 25, 2023
* Boilerplate scripts to install modules on Ascent via submodule Spack * Fix '--nnodes'-->'-nodes' on Ascent * Improve Ascent env.sh * [email protected] on Ascent * Apply pre-commmit fixes * Relax constraints on exago dependencies on Ascent and build ~python * concretizer: reuse was causing several packages to be duplicated in the environment. Require clean concretizations on Ascent. * Minor module update on Ascent * Add LAPACK_LIBRARIES to Ascent base script. CMAKE was picking up python's openblas otherwise. * Error with unzip. * Apply pre-commmit fixes * Add working build on ascent. * Add working gcc11.2.0 spack spec. * Add Ascent Spack pipeline. [ascent-rebuild] * Update gcc version to 11.2.0 in base.sh [skip-ci] * Fix stages of Ascent pipeline [ascent-rebuild] * Add working ascent spack build. * Add hiop@develop force rebuild to PNNL CI [ascent-rebuild] [newell-rebuild] [deception-rebuild] [incline-rebuild]. * Update Ascent spack built tcl modules * Only test ascent on tcl module update [ci-skip] * Update base.sh to disable python on ascent [skip ci] * Remove LAPACK_LIBRARIES spec [ascent-test] * Update ascent.gitlab-ci.yml to fix needs/dependencies [ascent-test] * Update deception spack built tcl modules - [deception-test] * Try again with Python, but have Spack build it instead of using the external module [ascent-rebuild] * Force python rebuild on ascent and use [email protected] on incline [ascent-rebuild] [newell-rebuild] [incline-rebuild] * Pin [email protected] on all CI platforms [decetpion-rebuild] [ascent-rebuild] [newell-rebuild] [incline-rebuild] * Fix false positive/negative in Ascent pipelines [deception-rebuild] [ascent-test] * Update incline spack built tcl modules - [incline-test] * Update newell spack built tcl modules - [newell-test] * Fix HiOp spec on Ascent [ascent-rebuild]. * Update deception spack built tcl modules - [deception-test] * Update CPU Spack build with issue for each failing build [ci skip] * Update Ascent spack built tcl modules [ascent-test] * Add 1.0.0 dep into CHANGELOG. * Add ascent-skip to CI to get tests passing [ascent-test] --------- Co-authored-by: nkoukpaizan <[email protected]> Co-authored-by: Cameron Rutherford <[email protected]> Co-authored-by: cameronrutherford <[email protected]> Co-authored-by: spack-auto-module <[email protected]>
bjpalmer
pushed a commit
that referenced
this pull request
Oct 30, 2023
* Boilerplate scripts to install modules on Ascent via submodule Spack * Fix '--nnodes'-->'-nodes' on Ascent * Improve Ascent env.sh * [email protected] on Ascent * Apply pre-commmit fixes * Relax constraints on exago dependencies on Ascent and build ~python * concretizer: reuse was causing several packages to be duplicated in the environment. Require clean concretizations on Ascent. * Minor module update on Ascent * Add LAPACK_LIBRARIES to Ascent base script. CMAKE was picking up python's openblas otherwise. * Error with unzip. * Apply pre-commmit fixes * Add working build on ascent. * Add working gcc11.2.0 spack spec. * Add Ascent Spack pipeline. [ascent-rebuild] * Update gcc version to 11.2.0 in base.sh [skip-ci] * Fix stages of Ascent pipeline [ascent-rebuild] * Add working ascent spack build. * Add hiop@develop force rebuild to PNNL CI [ascent-rebuild] [newell-rebuild] [deception-rebuild] [incline-rebuild]. * Update Ascent spack built tcl modules * Only test ascent on tcl module update [ci-skip] * Update base.sh to disable python on ascent [skip ci] * Remove LAPACK_LIBRARIES spec [ascent-test] * Update ascent.gitlab-ci.yml to fix needs/dependencies [ascent-test] * Update deception spack built tcl modules - [deception-test] * Try again with Python, but have Spack build it instead of using the external module [ascent-rebuild] * Force python rebuild on ascent and use [email protected] on incline [ascent-rebuild] [newell-rebuild] [incline-rebuild] * Pin [email protected] on all CI platforms [decetpion-rebuild] [ascent-rebuild] [newell-rebuild] [incline-rebuild] * Fix false positive/negative in Ascent pipelines [deception-rebuild] [ascent-test] * Update incline spack built tcl modules - [incline-test] * Update newell spack built tcl modules - [newell-test] * Fix HiOp spec on Ascent [ascent-rebuild]. * Update deception spack built tcl modules - [deception-test] * Update CPU Spack build with issue for each failing build [ci skip] * Update Ascent spack built tcl modules [ascent-test] * Add 1.0.0 dep into CHANGELOG. * Add ascent-skip to CI to get tests passing [ascent-test] --------- Co-authored-by: nkoukpaizan <[email protected]> Co-authored-by: Cameron Rutherford <[email protected]> Co-authored-by: cameronrutherford <[email protected]> Co-authored-by: spack-auto-module <[email protected]>
bjpalmer
pushed a commit
that referenced
this pull request
Nov 9, 2023
* Boilerplate scripts to install modules on Ascent via submodule Spack * Fix '--nnodes'-->'-nodes' on Ascent * Improve Ascent env.sh * [email protected] on Ascent * Apply pre-commmit fixes * Relax constraints on exago dependencies on Ascent and build ~python * concretizer: reuse was causing several packages to be duplicated in the environment. Require clean concretizations on Ascent. * Minor module update on Ascent * Add LAPACK_LIBRARIES to Ascent base script. CMAKE was picking up python's openblas otherwise. * Error with unzip. * Apply pre-commmit fixes * Add working build on ascent. * Add working gcc11.2.0 spack spec. * Add Ascent Spack pipeline. [ascent-rebuild] * Update gcc version to 11.2.0 in base.sh [skip-ci] * Fix stages of Ascent pipeline [ascent-rebuild] * Add working ascent spack build. * Add hiop@develop force rebuild to PNNL CI [ascent-rebuild] [newell-rebuild] [deception-rebuild] [incline-rebuild]. * Update Ascent spack built tcl modules * Only test ascent on tcl module update [ci-skip] * Update base.sh to disable python on ascent [skip ci] * Remove LAPACK_LIBRARIES spec [ascent-test] * Update ascent.gitlab-ci.yml to fix needs/dependencies [ascent-test] * Update deception spack built tcl modules - [deception-test] * Try again with Python, but have Spack build it instead of using the external module [ascent-rebuild] * Force python rebuild on ascent and use [email protected] on incline [ascent-rebuild] [newell-rebuild] [incline-rebuild] * Pin [email protected] on all CI platforms [decetpion-rebuild] [ascent-rebuild] [newell-rebuild] [incline-rebuild] * Fix false positive/negative in Ascent pipelines [deception-rebuild] [ascent-test] * Update incline spack built tcl modules - [incline-test] * Update newell spack built tcl modules - [newell-test] * Fix HiOp spec on Ascent [ascent-rebuild]. * Update deception spack built tcl modules - [deception-test] * Update CPU Spack build with issue for each failing build [ci skip] * Update Ascent spack built tcl modules [ascent-test] * Add 1.0.0 dep into CHANGELOG. * Add ascent-skip to CI to get tests passing [ascent-test] --------- Co-authored-by: nkoukpaizan <[email protected]> Co-authored-by: Cameron Rutherford <[email protected]> Co-authored-by: cameronrutherford <[email protected]> Co-authored-by: spack-auto-module <[email protected]>
bjpalmer
pushed a commit
that referenced
this pull request
Nov 20, 2023
* Boilerplate scripts to install modules on Ascent via submodule Spack * Fix '--nnodes'-->'-nodes' on Ascent * Improve Ascent env.sh * [email protected] on Ascent * Apply pre-commmit fixes * Relax constraints on exago dependencies on Ascent and build ~python * concretizer: reuse was causing several packages to be duplicated in the environment. Require clean concretizations on Ascent. * Minor module update on Ascent * Add LAPACK_LIBRARIES to Ascent base script. CMAKE was picking up python's openblas otherwise. * Error with unzip. * Apply pre-commmit fixes * Add working build on ascent. * Add working gcc11.2.0 spack spec. * Add Ascent Spack pipeline. [ascent-rebuild] * Update gcc version to 11.2.0 in base.sh [skip-ci] * Fix stages of Ascent pipeline [ascent-rebuild] * Add working ascent spack build. * Add hiop@develop force rebuild to PNNL CI [ascent-rebuild] [newell-rebuild] [deception-rebuild] [incline-rebuild]. * Update Ascent spack built tcl modules * Only test ascent on tcl module update [ci-skip] * Update base.sh to disable python on ascent [skip ci] * Remove LAPACK_LIBRARIES spec [ascent-test] * Update ascent.gitlab-ci.yml to fix needs/dependencies [ascent-test] * Update deception spack built tcl modules - [deception-test] * Try again with Python, but have Spack build it instead of using the external module [ascent-rebuild] * Force python rebuild on ascent and use [email protected] on incline [ascent-rebuild] [newell-rebuild] [incline-rebuild] * Pin [email protected] on all CI platforms [decetpion-rebuild] [ascent-rebuild] [newell-rebuild] [incline-rebuild] * Fix false positive/negative in Ascent pipelines [deception-rebuild] [ascent-test] * Update incline spack built tcl modules - [incline-test] * Update newell spack built tcl modules - [newell-test] * Fix HiOp spec on Ascent [ascent-rebuild]. * Update deception spack built tcl modules - [deception-test] * Update CPU Spack build with issue for each failing build [ci skip] * Update Ascent spack built tcl modules [ascent-test] * Add 1.0.0 dep into CHANGELOG. * Add ascent-skip to CI to get tests passing [ascent-test] --------- Co-authored-by: nkoukpaizan <[email protected]> Co-authored-by: Cameron Rutherford <[email protected]> Co-authored-by: cameronrutherford <[email protected]> Co-authored-by: spack-auto-module <[email protected]>
cameronrutherford
added a commit
that referenced
this pull request
Nov 28, 2023
* Boilerplate scripts to install modules on Ascent via submodule Spack * Fix '--nnodes'-->'-nodes' on Ascent * Improve Ascent env.sh * [email protected] on Ascent * Apply pre-commmit fixes * Relax constraints on exago dependencies on Ascent and build ~python * concretizer: reuse was causing several packages to be duplicated in the environment. Require clean concretizations on Ascent. * Minor module update on Ascent * Add LAPACK_LIBRARIES to Ascent base script. CMAKE was picking up python's openblas otherwise. * Error with unzip. * Apply pre-commmit fixes * Add working build on ascent. * Add working gcc11.2.0 spack spec. * Add Ascent Spack pipeline. [ascent-rebuild] * Update gcc version to 11.2.0 in base.sh [skip-ci] * Fix stages of Ascent pipeline [ascent-rebuild] * Add working ascent spack build. * Add hiop@develop force rebuild to PNNL CI [ascent-rebuild] [newell-rebuild] [deception-rebuild] [incline-rebuild]. * Update Ascent spack built tcl modules * Only test ascent on tcl module update [ci-skip] * Update base.sh to disable python on ascent [skip ci] * Remove LAPACK_LIBRARIES spec [ascent-test] * Update ascent.gitlab-ci.yml to fix needs/dependencies [ascent-test] * Update deception spack built tcl modules - [deception-test] * Try again with Python, but have Spack build it instead of using the external module [ascent-rebuild] * Force python rebuild on ascent and use [email protected] on incline [ascent-rebuild] [newell-rebuild] [incline-rebuild] * Pin [email protected] on all CI platforms [decetpion-rebuild] [ascent-rebuild] [newell-rebuild] [incline-rebuild] * Fix false positive/negative in Ascent pipelines [deception-rebuild] [ascent-test] * Update incline spack built tcl modules - [incline-test] * Update newell spack built tcl modules - [newell-test] * Fix HiOp spec on Ascent [ascent-rebuild]. * Update deception spack built tcl modules - [deception-test] * Update CPU Spack build with issue for each failing build [ci skip] * Update Ascent spack built tcl modules [ascent-test] * Add 1.0.0 dep into CHANGELOG. * Add ascent-skip to CI to get tests passing [ascent-test] --------- Co-authored-by: nkoukpaizan <[email protected]> Co-authored-by: Cameron Rutherford <[email protected]> Co-authored-by: cameronrutherford <[email protected]> Co-authored-by: spack-auto-module <[email protected]>
cameronrutherford
added a commit
that referenced
this pull request
Nov 29, 2023
* only print error messages if mpi rank is 0 * add rank check for num ranks * have non-zero ranks exit gracefully when throwing exago error * pflow functionality tests fully mpi aware * add logging rank variable * Apply pre-commmit fixes * Deleted unused header file. * Brought SCOPFLOW test driver in line with PFLOW driver. * Applied additional changes to selfcheck.cpp file for PFLOW, SOPFLOW and SCOPFLOW to adapt tests for running on multiple MPI ranks. * Apply pre-commmit fixes * Initialized some variables that were not getting properly set for serial test case. * only print error messages if mpi rank is 0 * pflow functionality tests fully mpi aware * add logging rank variable * Apply pre-commmit fixes * Deleted unused header file. * Brought SCOPFLOW test driver in line with PFLOW driver. * Applied additional changes to selfcheck.cpp file for PFLOW, SOPFLOW and SCOPFLOW to adapt tests for running on multiple MPI ranks. * Apply pre-commmit fixes * Update summit modules (#21) * Minor fix for Summit build system * Fix '--nnodes'-->'-nodes' on Summit * Attempt to update Summit modules * Reinstall Ginkgo and python dependencies on Summit * Enforce [email protected] on Summit * Specify RelWithDebInfo for ExaGO and HiOp on Summit * Update Spack * Relax constraints on exago dependencies on Summit * Add constraints on HiOp in the spack config. Part of the ExaGO package was conflicting with building HiOp in release mode. * Cleaner module install on Summit * Update spack_cpu_build.yaml to work without fork * Update .github/workflows/spack_cpu_build.yaml * Update Spack * Try updating pybind11 submodule to see if it fixes errors with exago+python builds --------- Co-authored-by: Cameron Rutherford <[email protected]> * OPFLOW with RAJA/HIOP sparse GPU solvers (#8) * OPFLOW: initial implementation of RAJA/HiOp sparse GPU-based solver WIP - HIOP Sparse solver with GPU model OPFLOW: Started work on support for HIOP sparse solver interface for GPUs. Added a copy of hiop sparse solver interface. OPFLOW: Added model skeleton for GPU sparse version (copying from pbpolrajahiop) Fixed build Did some copy paste to add a test for HIOPSPARSE. This test is not actually functional yet. Started updating the hiopsparse model and solver code. More work on updating the solver and model Added scalar and vector unit tests for model to be used with HIOP sparse solver on GPU Apply cmake lint Fix unit tests. Set the size of array when using Umpire memset. Code formatting Some minor changes to get PBPOLRAJAHIOPSPARSE model code to compile Separate BUS/LINE/GEN/.../Param structs into reusable module Minor edit Rename files Fix typo Use BUS/LINE/GEN/.../Param structs in Raja HiOp Sparse model (compiles) Updating HIOP sparse solver GPU API Completed bounds kernels Completed scalar and vector functions WIP - HIOP Sparse solver with GPU model OPFLOW: Started work on support for HIOP sparse solver interface for GPUs. Added a copy of hiop sparse solver interface. OPFLOW: Added model skeleton for GPU sparse version (copying from pbpolrajahiop) Fixed build Did some copy paste to add a test for HIOPSPARSE. This test is not actually functional yet. Started updating the hiopsparse model and solver code. More work on updating the solver and model Added scalar and vector unit tests for model to be used with HIOP sparse solver on GPU Apply cmake lint Fix unit tests. Set the size of array when using Umpire memset. Code formatting Rename files Use BUS/LINE/GEN/.../Param structs in Raja HiOp Sparse model (compiles) Updating HIOP sparse solver GPU API Completed bounds kernels Jacobian and Hessian for sparse model (CPU --> GPU copy) Use correct array lengths in Eq. Jacobian Fix bug in Jacobian. Fix unused variable/parameter errors OPFLOW: rework solution callback for RAJA/HIOP GPU-based solver Formatting changes * Add unit test for RAJA/HiOp Sparse GPU model (9-bus only) * Apply pre-commmit fixes * Add test for 200-bus case * Apply pre-commmit fixes --------- Co-authored-by: Abhyankar, Shrirang G <[email protected]> * Upgrade ascent build system and use `[email protected]` on CI platforms (#20) * Boilerplate scripts to install modules on Ascent via submodule Spack * Fix '--nnodes'-->'-nodes' on Ascent * Improve Ascent env.sh * [email protected] on Ascent * Apply pre-commmit fixes * Relax constraints on exago dependencies on Ascent and build ~python * concretizer: reuse was causing several packages to be duplicated in the environment. Require clean concretizations on Ascent. * Minor module update on Ascent * Add LAPACK_LIBRARIES to Ascent base script. CMAKE was picking up python's openblas otherwise. * Error with unzip. * Apply pre-commmit fixes * Add working build on ascent. * Add working gcc11.2.0 spack spec. * Add Ascent Spack pipeline. [ascent-rebuild] * Update gcc version to 11.2.0 in base.sh [skip-ci] * Fix stages of Ascent pipeline [ascent-rebuild] * Add working ascent spack build. * Add hiop@develop force rebuild to PNNL CI [ascent-rebuild] [newell-rebuild] [deception-rebuild] [incline-rebuild]. * Update Ascent spack built tcl modules * Only test ascent on tcl module update [ci-skip] * Update base.sh to disable python on ascent [skip ci] * Remove LAPACK_LIBRARIES spec [ascent-test] * Update ascent.gitlab-ci.yml to fix needs/dependencies [ascent-test] * Update deception spack built tcl modules - [deception-test] * Try again with Python, but have Spack build it instead of using the external module [ascent-rebuild] * Force python rebuild on ascent and use [email protected] on incline [ascent-rebuild] [newell-rebuild] [incline-rebuild] * Pin [email protected] on all CI platforms [decetpion-rebuild] [ascent-rebuild] [newell-rebuild] [incline-rebuild] * Fix false positive/negative in Ascent pipelines [deception-rebuild] [ascent-test] * Update incline spack built tcl modules - [incline-test] * Update newell spack built tcl modules - [newell-test] * Fix HiOp spec on Ascent [ascent-rebuild]. * Update deception spack built tcl modules - [deception-test] * Update CPU Spack build with issue for each failing build [ci skip] * Update Ascent spack built tcl modules [ascent-test] * Add 1.0.0 dep into CHANGELOG. * Add ascent-skip to CI to get tests passing [ascent-test] --------- Co-authored-by: nkoukpaizan <[email protected]> Co-authored-by: Cameron Rutherford <[email protected]> Co-authored-by: cameronrutherford <[email protected]> Co-authored-by: spack-auto-module <[email protected]> * Add Spack CPU build with `exago+hiop+raja~ipopt ^hiop+raja~sparse` (#41) * Add CPU build with hiop+sparse and exago~ipopt+hiop+raja * Update .github/workflows/spack_cpu_build.yaml * `+mpi` to `+raja` CPU build * Add HIOPRAJASPARSE model if sparse and raja enabled * Fix other HIOPRAJASPARSE ifdef * pflow functionality tests fully mpi aware * add logging rank variable * Apply pre-commmit fixes * Deleted unused header file. * Brought SCOPFLOW test driver in line with PFLOW driver. * Applied additional changes to selfcheck.cpp file for PFLOW, SOPFLOW and SCOPFLOW to adapt tests for running on multiple MPI ranks. * Apply pre-commmit fixes * Apply pre-commmit fixes * Updated third party libraries * Set more default values in selfcheck.cpp to get rid of uninitialized variables errors in Valgrind and modified a few test values so that tests pass. * Apply pre-commmit fixes * Fixed up some preprocessor glitches that got introduced in the rebase. * Modified versions on pybind11 and spack to match develop. * Fix remaining issues in merge request. * Apply pre-commmit fixes * Fixed preprocessor directives to match develop branch. * Modified constructor of FunctionalityTestContext to get rid of a bunch of code checking MPI calls. * Apply pre-commmit fixes * Remove logging ranks variable. --------- Co-authored-by: Jaelyn Litzinger <[email protected]> Co-authored-by: Bruce J Palmer <[email protected]> Co-authored-by: Nicholson Koukpaizan <[email protected]> Co-authored-by: Cameron Rutherford <[email protected]> Co-authored-by: Bill <[email protected]> Co-authored-by: Abhyankar, Shrirang G <[email protected]> Co-authored-by: nkoukpaizan <[email protected]> Co-authored-by: cameronrutherford <[email protected]> Co-authored-by: spack-auto-module <[email protected]> Co-authored-by: Bruce J Palmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the Ascent build system to use a Spack submodule and install the dependencies in a common shared space.
This is not ready to merge yet (See #19).