-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spack GitHub action #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we still have other work to do with submodules, these builds should catch some errors we are seeing in xSDK pipelines and so are useful in their current state. This will be improved in the future.
Currently each of the spack builds take at least 30min of GitHub runner time, so we should both minimize the set of configurations we test, and also try to only run CI infrequently (maybe only on merges into develop from now on?) |
https://github.com/pnnl/ExaGO/actions/runs/6279332431/job/17054811101?pr=15 - really interesting bug here. This is probably one of the first times that someone has built exago in this minimal config, so we have an error that we don't Normally something like See spack PR for the fix that is used in this PR (ideally Spack PR is merged before this) spack/spack#40188 |
f4fd508
to
473e3db
Compare
xsdk-project/xsdk-issues#220 - finally reproduced this issue in the pipelines here. Just a matter of actually fixing the issue now. |
@ryandanehy and @abhyshr I think this is ready to go when CI passes, so I would love at least one more review of this finished product before merging. This also resolves issues with xSDK build failures, so good to get this merged soon. |
See #17 for issue identified when building |
See #18 and LLNL/hiop#662 for issues with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This modifies exago's spack package, so spack/spack#40188 should be merged before this, and submodule updated accordingly.
Closes #11