Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow clipping planes to be used with Outlines #2133

Merged
merged 7 commits into from
Jan 12, 2025

Conversation

Archimagus
Copy link
Contributor

@Archimagus Archimagus commented Oct 22, 2024

Why

resolves #2132

What

Added clipping planes to the Outlines object.

Checklist

  • [ X] Documentation updated
  • Ready to be merged

Copy link

vercel bot commented Oct 22, 2024

@Archimagus is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codesandbox-ci bot commented Oct 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@CodyJasonBennett CodyJasonBennett changed the title Allow clipping planes to be used with Outlines fix: allow clipping planes to be used with Outlines Oct 24, 2024
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 7:44pm

@Archimagus
Copy link
Contributor Author

Is this missing anything for it to be merged? The process seems a bit different than the last PR I made.

@CodyJasonBennett CodyJasonBennett merged commit 3463269 into pmndrs:master Jan 12, 2025
3 of 4 checks passed
Copy link

🎉 This PR is included in version 9.120.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outlines should be able to be clipping with clipping planes.
2 participants