-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/useSpriteLoader #1790
Merged
Merged
Feat/useSpriteLoader #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0e6c6a0:
|
🎉 This PR is included in version 9.97.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Added the
useSpriteLoader
to better streamline sprite loading and be able to batch multiple sprites into one sprite-sheet, load it once and use it across multiple SpriteAnimator components.Modified the SpriteAnimator code to internally also use
useSpriteLoader
in order to not break compatibility with previous versions and still be able to load textures directly from the SpriteAnimator parameters.This way loading and parsing live on the loader, which makes it easier for new formats to be supported without jeopardising or bloating the SpriteAnimator component.
useSpriteLoader
supports all the formats that SpriteAnimator used to support:Sample: https://codesandbox.io/p/sandbox/r3f-sprite-animator-v3-0-usespriteloader-wip-forked-fyysqy
What
Added
useSpriteLoader
under loaders on README and added the component fileModified
SpriteAnimator
to internally useuseSpriteLoader
as wellChecklist