Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ScrollControls): fix typo and default value description for damping #1757

Merged
merged 1 commit into from
Dec 19, 2023
Merged

docs(ScrollControls): fix typo and default value description for damping #1757

merged 1 commit into from
Dec 19, 2023

Conversation

klingat
Copy link
Contributor

@klingat klingat commented Dec 18, 2023 •
edited
Loading

Why

  • There is a typo in the ScrollControls storybook documentation

What

  • Fixed the typo, and the default value (see screenshots in QA section below)
    • Horontal -> Horizontal
    • Default damping descriptions says 0.2s when it is actually 0.25s

Checklist

  • Documentation updated
  • Ready to be merged

To QA

  1. Run yarn storybook
  2. Go to Storybook -> ScrollControls, see documentation
    Before:
Screenshot 2023-12-18 at 1 31 42 PM After: Screenshot 2023-12-18 at 1 32 27 PM

@vercel Vercel
Copy link

vercel bot commented Dec 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 9:39pm

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 68afa95:

Sandbox Source
eager-fog-gnsg43 Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@CodyJasonBennett CodyJasonBennett merged commit 8f0a045 into pmndrs:master Dec 19, 2023
4 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 9.92.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klingat @CodyJasonBennett