Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow null environment in StageProps #1746

Merged

Conversation

gingman
Copy link
Contributor

@gingman gingman commented Dec 8, 2023

Why

There was no typed way to skip the environment on a Stage. To make it work, we needed to use null as any as a prop.

What

We support passing a null value to the environment value in StageProps
Resolves #766

Checklist

  • Documentation updated (example)
  • Storybook entry added (example)
  • Ready to be merged

Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 8:10pm

Copy link

codesandbox-ci bot commented Dec 8, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6812778:

Sandbox Source
cold-brook-ldv74y Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration
exciting-sammet-jlgcx9 Issue #766

@CodyJasonBennett CodyJasonBennett merged commit 2c0c7a2 into pmndrs:master Dec 9, 2023
4 checks passed
Copy link

github-actions bot commented Dec 9, 2023

🎉 This PR is included in version 9.90.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In <Stage> , I can't set environment to undefined to stop the request to hdr
2 participants