Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): update @mediapipe/tasks-vision #1716

Merged

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Nov 13, 2023

Why

Using moduleResolution: "bundler" with @react-three/drei fails because @mediapipe/[email protected] does not have any recognizable types when using moduleResolution: "bundler":

image

This is (somewhat) fixed with later versions of @mediapipe/tasks-vision:

image

What

Update @mediapip/tasks-vision.

Checklist

  • Documentation updated (example)
  • Storybook entry added (example)
  • Ready to be merged

Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 4:56pm

Copy link

codesandbox-ci bot commented Nov 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8a4bb4e:

Sandbox Source
wonderful-wave-vqvq3q Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@Methuselah96 Methuselah96 changed the title fix: update @mediapipe/tasks-vision fix(types): update @mediapipe/tasks-vision Nov 13, 2023
@CodyJasonBennett CodyJasonBennett merged commit 6591c01 into pmndrs:master Nov 14, 2023
2 checks passed
Copy link

🎉 This PR is included in version 9.88.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Methuselah96 Methuselah96 deleted the update-mediapipe-tasks-vision branch November 14, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants