AccumulatedShadows NPE protection

[supertick]

Why

When component is unmounted it throws.
The way its currently written

    React.useLayoutEffect(() => {
      const group = gLights.current
      if (parent) parent.lights.set(group.uuid, api)
      return () => void parent.lights.delete(group.uuid)
    }, [parent, api])

The check for valid parent is done for the lights.set, but there is no check on the

      return () => void parent.lights.delete(group.uuid)

so if parent is null this ^ line throws

What

prevents AccumulatedShadows from throwing when parent is null

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
drei	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 15, 2023 3:50pm

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2404ee2:

Sandbox	Source
vigorous-lake-mz6p65	Configuration
Ground reflections and video textures	Configuration
arc-x-pmndrs-colors	Configuration

[drcmda]

hi @supertick, thanks! could you do this instead?

      if (parent) parent?.lights.set(group.uuid, api)
      return () => void parent?.lights.delete(group.uuid)

and w/o semicolons please due to the prettier config we use.

[supertick]

Sure, updated.

• removed the first parent? because its already tested with if (parent)
• improved formatting 👍

[github-actions]

🎉 This PR is included in version 9.92.5 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀