Skip to content

Commit

Permalink
Rename CloseFormPacket to ClientboundCloseFormPacket (#248)
Browse files Browse the repository at this point in the history
Parity with vanilla protocol convention
  • Loading branch information
dries-c authored Jul 10, 2024
1 parent 0e90215 commit bb23db5
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@

use pocketmine\network\mcpe\protocol\serializer\PacketSerializer;

class CloseFormPacket extends DataPacket implements ClientboundPacket{
public const NETWORK_ID = ProtocolInfo::CLOSE_FORM_PACKET;
class ClientboundCloseFormPacket extends DataPacket implements ClientboundPacket{
public const NETWORK_ID = ProtocolInfo::CLIENTBOUND_CLOSE_FORM_PACKET;

/**
* @generate-create-func
Expand Down
2 changes: 1 addition & 1 deletion src/PacketHandlerDefaultImplTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -802,7 +802,7 @@ public function handleAwardAchievement(AwardAchievementPacket $packet) : bool{
return false;
}

public function handleCloseForm(CloseFormPacket $packet) : bool{
public function handleCloseForm(ClientboundCloseFormPacket $packet) : bool{
return false;
}
}
2 changes: 1 addition & 1 deletion src/PacketHandlerInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -408,5 +408,5 @@ public function handleSetHud(SetHudPacket $packet) : bool;

public function handleAwardAchievement(AwardAchievementPacket $packet) : bool;

public function handleCloseForm(CloseFormPacket $packet) : bool;
public function handleCloseForm(ClientboundCloseFormPacket $packet) : bool;
}
2 changes: 1 addition & 1 deletion src/PacketPool.php
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ public function __construct(){
$this->registerPacket(new SetPlayerInventoryOptionsPacket());
$this->registerPacket(new SetHudPacket());
$this->registerPacket(new AwardAchievementPacket());
$this->registerPacket(new CloseFormPacket());
$this->registerPacket(new ClientboundCloseFormPacket());
}

public function registerPacket(Packet $packet) : void{
Expand Down
2 changes: 1 addition & 1 deletion src/ProtocolInfo.php
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,6 @@ private function __construct(){
public const SET_PLAYER_INVENTORY_OPTIONS_PACKET = 0x133;
public const SET_HUD_PACKET = 0x134;
public const AWARD_ACHIEVEMENT_PACKET = 0x135;
public const CLOSE_FORM_PACKET = 0x136;
public const CLIENTBOUND_CLOSE_FORM_PACKET = 0x136;

}

0 comments on commit bb23db5

Please sign in to comment.