Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PDE-429] Make sure YieldToken and AssetToken are upgradeable #153

Merged
merged 17 commits into from
Jan 13, 2025
Merged

Conversation

ungaro
Copy link
Contributor

@ungaro ungaro commented Jan 10, 2025

What's new in this PR?

YieldToken and AssetToken are upgradeable
some tests are failing, they will be handled in a different PR.

@ungaro ungaro requested a review from eyqs January 10, 2025 21:57
@ungaro ungaro marked this pull request as draft January 10, 2025 21:58
@ungaro ungaro marked this pull request as ready for review January 10, 2025 22:06
Copy link
Member

@eyqs eyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add onlyInitializing reinitializers to AssetToken and YieldToken?

smart-wallets/test/YieldToken.t.sol Outdated Show resolved Hide resolved
smart-wallets/script/DeployAssetToken.s.sol Outdated Show resolved Hide resolved
smart-wallets/script/DeployYieldToken.s.sol Outdated Show resolved Hide resolved
smart-wallets/src/token/AssetToken.sol Outdated Show resolved Hide resolved
smart-wallets/src/token/YieldDistributionToken.sol Outdated Show resolved Hide resolved
smart-wallets/src/token/YieldToken.sol Outdated Show resolved Hide resolved
@ungaro
Copy link
Contributor Author

ungaro commented Jan 13, 2025

onlyInitializing should be on YieldDistributionToken
__YieldDistributionToken_init has it.

@ungaro ungaro requested a review from eyqs January 13, 2025 20:20
@ungaro ungaro merged commit dfa1000 into main Jan 13, 2025
1 check passed
@ungaro ungaro deleted the alp/PDE-429 branch January 13, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants