[FEA-792] added multiplier #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ran forge fmt |
eyqs
reviewed
Dec 18, 2024
| } else if (flightClass == 5) { | ||
| multiplier = 300; // 3x (scaled by 100) | ||
| } else if (flightClass == 6) { | ||
| multiplier = 500; // 5x (scaled by 100) |
There was a problem hiding this comment.
Add comments on what each flight class is (Economy, Plus, etc.)
There was a problem hiding this comment.
There must be a more efficient way of doing this? e.g. uint256[] constant multipliers = [0, 1, 11, 125, 200, 300, 500]; - check if this actually saves gas
There was a problem hiding this comment.
maybe something like this.
uint256[6] memory multipliers = [100, 110, 125, 200, 300, 500];
if (flightClass == 0 || flightClass > 6) {
revert InvalidFlightClass(flightClass);
}
return (baseAmount * multipliers[flightClass - 1]) / 100;```
eyqs
approved these changes
Dec 18, 2024
| } else if (flightClass == 5) { | ||
| multiplier = 300; // 3x (scaled by 100) | ||
| } else if (flightClass == 6) { | ||
| multiplier = 500; // 5x (scaled by 100) |
There was a problem hiding this comment.
There must be a more efficient way of doing this? e.g. uint256[] constant multipliers = [0, 1, 11, 125, 200, 300, 500]; - check if this actually saves gas
|
made it to array, for 6 classes it's better Upgraded forge |
|
Class 6 if else is better, Class 9 and above array works better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Add multiplier for flight class