Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section and colspan on formulary #345

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

calidadcarm
Copy link

Add section on formulary:

$GO_FIELDS['section']['name'] = __("Example secction");
$GO_FIELDS['section']['field'] = 'sectionRow';
$GO_FIELDS['section']['input_type'] = 'sectionRow';
$GO_FIELDS['section']['colums'] = '4';

Add Colspan on formulary:

$GO_FIELDS['comment']['name'] = __("Comments");
$GO_FIELDS['comment']['field'] = 'comment';
$GO_FIELDS['comment']['input_type'] = 'multitext';
$GO_FIELDS['gestion']['colums'] = '3'; //[CRI] : colums - Add colspan on formulary

Add section on formulary:

$GO_FIELDS['section']['name']       = __("Example secction");
$GO_FIELDS['section']['field']      = 'sectionRow';
$GO_FIELDS['section']['input_type'] = 'sectionRow';
$GO_FIELDS['section']['colums']     = '4';

Add Colspan on formulary:

$GO_FIELDS['comment']['name']       = __("Comments");
$GO_FIELDS['comment']['field']      = 'comment';
$GO_FIELDS['comment']['input_type'] = 'multitext';
$GO_FIELDS['gestion']['colums']     = '3'; //[CRI] : colums - Add colspan on formulary
@calidadcarm
Copy link
Author

I request to contribute with this new functionality, it allows adjusting the fields to the form and creating sections to delimit the fields by theme

$GO_FIELDS['gestion']['colums']
Vs
$GO_FIELDS['comment']['colums']
Copy link
Contributor

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the comments you add to delimitate your changes and remove commented lines of code ?
It does not help to have a comfortable diff.

@cedric-anne cedric-anne changed the base branch from develop to master October 10, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants