Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare release of v2.4.0 (#293) #303

Merged
merged 1 commit into from
Oct 14, 2024
Merged

prepare release of v2.4.0 (#293) #303

merged 1 commit into from
Oct 14, 2024

Conversation

stklcode
Copy link
Contributor

@stklcode stklcode commented Aug 4, 2024 •
edited
Loading

  • add changelog entries
  • raise version number to 2.4.0
  • raise "Tested up to:" to 6.6
  • unify "since" comments

If you want to test the new plugin, you may use this package and install at own risk:

@stklcode stklcode added this to the 2.4.0 milestone Aug 4, 2024
@stklcode
Copy link
Contributor Author

stklcode commented Aug 5, 2024

Briefly tested the release myself in a test container:

  • both nginx 1.26.1 and Apache httpd 2.4.62
  • PHP 8.3.10
  • WP 6.6.1
  • MySQL 8.4.2
  • Valkey 7.2.6

Standard workflows look good, no obvious regressions. Not every edge case testet though.

@pluginkollektiv pluginkollektiv deleted a comment from sonarqubecloud bot Sep 22, 2024
@stklcode
Copy link
Contributor Author

Updated after APC removal (#304, #305) and attached a new beta2.

@Zodiac1978
Copy link
Member

Zodiac1978 commented Oct 6, 2024 •
edited
Loading

The semicolons after the Ifmodule blocks are breaking everything, at least for me (every request fails with an error 500).

If I remove them, it works.

I have never seen them anywhere and cannot find them in the Apache docs as allowed.

@stklcode
Copy link
Contributor Author

stklcode commented Oct 6, 2024

Good catch, apparently s/&gt/>/g left a stray semicolon 🙈 Should be fixed by #309

@stklcode stklcode force-pushed the release/2.4.0 branch 2 times, most recently from 10391ab to 8bfc9b1 Compare October 14, 2024 16:48
@stklcode
prepare release of v2.4.0 (#293) (#303)
712109c 
* add changelog entries
* raise version number to 2.4.0
* raise "Tested up to:" to 6.6
* unify "since" comments
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stklcode stklcode merged commit 712109c into develop Oct 14, 2024
15 checks passed
@stklcode stklcode deleted the release/2.4.0 branch October 14, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stklcode @Zodiac1978