-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move theming to its own package #2337
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…CI as it's already done when creating the preview on vercel
@plouc Any update on this one? It would be useful to get the d3-color vulnerability fix released. |
@plouc d3-color vulnerability has posed security challenges for nivo's usage. Recent upgrade of nivo hasn't resolved it because the version upgrade has brought ESM & CJS modules conflict. Any information about the release date would be greatly appreciated. |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
@nivo/core
contains a bit of everything, and it can lead to circular dependencies (it's the case with@nivo/tooltip
for example), so I decided to move it to its own package.The added benefit is that now this part will be in TypeScript, as
@nivo/core
is unfortunately still not.Extra features:
outlineWidth
,outlineColor
andoutlineOpacity
via the theme object.This introduces some breaking changes:
useTheme
, previously imported from@nivo/core
, now it's defined in@nivo/theming
@nivo/theming
package.