Add DeepnoteRenderer to pio.renderers #4389
Conversation
jakubzitny
force-pushed
the
jz/add-deepnote-renderer
branch
from
304f5ea
to
46d5d08
Compare
jakubzitny
force-pushed
the
jz/add-deepnote-renderer
branch
from
46d5d08
to
681376d
Compare
| @@ -74,7 +74,7 @@ fig | |||
|
|
|||
| > To be precise, figures will display themselves using the current default renderer when the two following conditions are true. First, the last expression in a cell must evaluate to a figure. Second, `plotly.py` must be running from within an `IPython` kernel. | |||
|
|
|||
| **In many contexts, an appropriate renderer will be chosen automatically and you will not need to perform any additional configuration.** These contexts include the classic [Jupyter Notebook](https://jupyter.org/), [JupyterLab](https://jupyterlab.readthedocs.io/en/stable/), [Visual Studio Code notebooks](https://code.visualstudio.com/docs/python/jupyter-support), [Google Colaboratory](https://colab.research.google.com/notebooks/intro.ipynb), [Kaggle](https://www.kaggle.com/kernels) notebooks, [Azure](https://notebooks.azure.com/) notebooks, and the [Python interactive shell](https://www.python.org/shell/). | |||
| **In many contexts, an appropriate renderer will be chosen automatically and you will not need to perform any additional configuration.** These contexts include the classic [Jupyter Notebook](https://jupyter.org/), [JupyterLab](https://jupyterlab.readthedocs.io/en/stable/), [Visual Studio Code notebooks](https://code.visualstudio.com/docs/python/jupyter-support), [Google Colaboratory](https://colab.research.google.com/notebooks/intro.ipynb), [Kaggle](https://www.kaggle.com/kernels) notebooks, [Azure](https://notebooks.azure.com/) notebooks, [Deepnote](https://deepnote.com/) notebooks, and the [Python interactive shell](https://www.python.org/shell/). | |||
There was a problem hiding this comment.
Are you planning to add a new auto-detection block then in _renderers.py?
There was a problem hiding this comment.
Good point, will do. Thanks.
| @@ -7,6 +7,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). | |||
| ### Fixed | |||
| - Repair crash on Matplotlib 3.8 related to get_offset_position [[#4372](https://github.com/plotly/plotly.py/pull/4372)], | |||
| - Handle deprecation of `pandas.Series.dt.to_pydatetime()` calls and suppress the `FutureWarning` they currently emit. [[#4379](https://github.com/plotly/plotly.py/pull/4379)] | |||
| - Add DeepnoteRenderer to pio.renderers [[#4389](https://github.com/plotly/plotly.py/pull/4389)] | |||
There was a problem hiding this comment.
I'd call this ### Added, rather than ### Fixed 😉
|
hi @jakubzitny |
gvwilson
added
feature
|
@alexcjohnson can you please have a look and let us know whether we should have someone pick this up and get it over the finish line? thanks - @gvwilson |
|
I'm happy for us to accept this PR - we have lots of renderers for other proprietary notebook systems, and we want plotly.py to work easily in all of them. But it really should be completed by someone from Deepnote, or an active Deepnote user, particularly the auto-detection part, they'll have much better context than we can about the most robust and future-proof way to interact with Deepnote. @jakubzitny are you still interested in completing this? Or is there someone else at Deepnote who would like to complete it? |
Adding a dedicated renderer for Deepnote notebooks, similar to ColabRenderer, CoCalcRenderer, or AzureRenderer.
Disclaimer: I am an engineer from Deepnote, we are requesting this after having a number of users of Deepnote misconfiguring renderers in Plotly which lead to broken chart rendering.
plotly.graph_objects, my modifications concern thecodegenfiles and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).