Fix acessibilidade #140
Merged
Fix acessibilidade #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajuste dos links vazios acontent, anavigation e afooter para atender os critérios de acessibilidade
21 tasks
hvelarde
requested changes
Oct 2, 2017
CHANGES.rst
Outdated
| @@ -4,7 +4,12 @@ Histórico de Alterações | |||
| 1.2.2 (unreleased) | |||
| ^^^^^^^^^^^^^^^^^^ | |||
|
|
|||
| - Nothing changed yet. | |||
| - Adiciona css ocultar os links de id acontent, afooter e anavigation. | |||
CHANGES.rst
Outdated
| - Adiciona css ocultar os links de id acontent, afooter e anavigation. | ||
| [idgserpro] | ||
|
|
||
| - Adiciona regra diazo para obter a tradução dos links de id acontent, afooter |
There was a problem hiding this comment.
Diazo, also, documentation is not code: make this one line.
| transaction.commit() | ||
|
|
||
| def base_test(self, cor): | ||
| """Teste base dos temas""" |
There was a problem hiding this comment.
all docstring must end with a "."
| @@ -166,7 +166,7 @@ | |||
|
|
|||
| <!-- Column 1 --> | |||
| <div id="navigation"> | |||
| <a name="anavigation" id="anavigation"></a> | |||
| <a name="anavigation" id="anavigation" class="anchor">menu</a> | |||
There was a problem hiding this comment.
the use of the name attribute is deprecated in HTML5:
There was a problem hiding this comment.
We didn't add this attribute, it was already available in the code. Since removing this is out of the scope of this PR, we're opening a new ticket do address it #141 in another branch.
hvelarde
approved these changes
Oct 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Com a aprovação desse PR, um release é útil para prosseguirmos removermos
@unittest.expectedFailurepresente em brasil.gov.portal que espera um release do brasil.gov.temas que possua essas regras no Diazo.