-
-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: render Ordertab only when it is active #6583
base: main
Are you sure you want to change the base?
fix: render Ordertab only when it is active #6583
Conversation
✅ Deploy Preview for plone-components canceled.
|
@stevepiercy @ichim-david @davisagli Please provide review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change in the change log entry.
@@ -0,0 +1 @@ | |||
You can now render the order side panel only when the 'Order' tab is active. Previously, the panel would render unnecessarily even when not active.@Abhishek-17h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can now render the order side panel only when the 'Order' tab is active. Previously, the panel would render unnecessarily even when not active.@Abhishek-17h | |
The Order side panel now renders only when the "Order" tab is active. Previously, the panel would render unnecessarily even when inactive. @Abhishek-17h |
This is a nice step forward. Thanks for your work on this. In the video, I noticed two things that I'd like to ask for opinions from the members of both the @plone/volto-accessibility and @plone/volto-team. Please don't make changes yet, but let's get some feedback.
|
Thank you, @stevepiercy, for your suggestions. I completely agree with your first suggestion regarding replacing the icon 🚫 with a "Loading" icon. In fact, I had initially considered implementing this change before raising the PR but decided to keep the existing behavior to gather feedback from the Volto team and accessibility experts. It's great to see that you noticed it too, as it reinforces the need for improvement in this area. Regarding your second suggestion, I think it’s a great idea, but I am concerned that its implementation might conflict with the main issue being addressed. Looking forward to hearing more thoughts from the Volto team and accessibility members on these points! |
7b06c00
to
bc449af
Compare
bc449af
to
8e02a2c
Compare
@ichim-david please provide review on this. |
@Abhishek-17h technically speaking what you did is what I've asked. The problem is that the UX isn't very good as it takes a long time to load even locally with a very fast MacBook pro.
See if you can introduce a loader to give some info to the user that the panel is loading. I would also try to look at the logic of the component and try to understand why it takes so long to load and if there is anything that can be done to speed it up. If we were to simply merge this change it would be a degradation of service of the order tab for the editor on account on having to wait so long to interact with it, especially on second time interactions on the same page. |
@ichim-david, I have watched your testing video and truly appreciate the time you took to explain everything in detail. I will implement the things you mentioned. Thank you for your guidance! |
The video showcases the behavior after the fix:
Screencast from 2025-01-13 09-17-05.webm
Closes #6492