-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Effective Volto 2023 #793
Merged
Merged
Effective Volto 2023 #793
Changes from 2 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
5e4b699
Update getting started
sneridagh 1beaba5
Add dataAdapter pattern
sneridagh b909010
Blocks layout and blocks styling updates
sneridagh b12dc17
theme addons
sneridagh 1fde2ac
Update addons testing
sneridagh 315e5fa
Update bypass cors local dev
sneridagh 503eeb3
Fixed dataAdapter pattern
sneridagh 7001254
Asyncconnect chapter
tiberiuichim fcb5999
Block styling chapter
tiberiuichim b66b813
BlockDataForm chapter
tiberiuichim 5eafc38
Addon dependencies chapter
tiberiuichim 1443ac6
How an addon works chapter
tiberiuichim 4ebb3f1
i18n chapter
tiberiuichim 3f438cf
Pipeline chapter
tiberiuichim 7b61429
SemanticUI chapter
tiberiuichim 01f9866
Use Released addons chapter
tiberiuichim daf6a71
View and use-repo-addon chapter
tiberiuichim ec04603
Webpack chapter
tiberiuichim e1af3f5
Babel and webpack
tiberiuichim 293f83a
Blocks chapter
tiberiuichim 1e57f64
Bootstrap chapter
tiberiuichim b7603f5
Configuration chapter
tiberiuichim 8bc77f5
Add some info in CORS
tiberiuichim 8c8ea3c
Multilingual and razzle
tiberiuichim fe86dfc
Redux chapter
tiberiuichim fbe0901
More docs
tiberiuichim 35fdd67
More docs on backend
tiberiuichim caa5505
Info on storybook
tiberiuichim 8ae8d5e
Fixes to jest.md
tiberiuichim beb7c3b
Merge branch 'main' into effectiveVolto2023
tiberiuichim c50ffd0
Add text to the seamless mode chapter
tiberiuichim adb59a9
Shuffle configuration in seamless
tiberiuichim cda43dc
Tweaks to component-registry and debugging
tiberiuichim 9e6a0ff
Tweak environmentvariables.md
tiberiuichim 004af08
Add details in icons.md
tiberiuichim 5e8115c
Small tweaks to lazyloading
tiberiuichim f59be22
More tweaks
tiberiuichim 07b73a6
Add info about the @URL value type
tiberiuichim c2eaf9c
Tweaks to seamlessmode chapter
tiberiuichim 3905037
Tweaks to testing
tiberiuichim 17f8dc8
Tweaks
tiberiuichim 3e964b1
Update intro page
tiberiuichim 990e152
Update intro page
tiberiuichim 463ecec
Update intro page
tiberiuichim bc2da38
Some minor typos and fixes
sneridagh 097f6f5
last amendments
sneridagh 99e4a21
Merge branch 'main' into effectiveVolto2023
sneridagh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pattern will cause confusion.
Why is the BlockDataForm looking for a dataAdapter for a certain block? (it's not explained that the BlockDataForm is used internally by the teaser block).
It's not explained how to register the data adapter (although this would be obvious, in theory). The data adapter function uses CamelCase naming, usually reserved for components.
I think it's dangerous to have the data adapter directly call
onChangeBlock
. I think it's better if the purity of the data operations is kept. No side-effects. If the data adapter is called too late in the data "fixing" chain, then we need to figure out a solution to call it sooner, at the top of the chain, at the level of the "big form".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tiberiuichim I completed the docs to make them more consistent and understandable.
Regarding the purity... we are already calling it virtually everywhere, since the default pattern is:
in all places. So calling it inside the dataAdapter is "legit", right? Granted, it could be handled better, but as a general improvement of the
BlockDataForm
.