When providing the UID or GID as a number the chart fails to deploy, … #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cilindrox
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
thanks for the contribution @JoelBChapmanII - LGTM, although my preference would be to use the quote function instead of the hard quotes.
Edit: also, if you could bump the chart version to a patch (0.1.7 afaict), we can release this straight away.
…adding quotations to where extraEnv lands the extra environment variables fixes the issue Updating method to quote the env values per PR conversation, updating chart version with a patch bump
cilindrox
approved these changes
Nov 14, 2023
Merged
JoelBChapmanII
force-pushed
the
master
branch
from
4a448ac to
7b961bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not see a contributing.md before opening this PR, if there are steps I've missed please let me know.
Problem: When specifying the gid (
PLEX_GID) or uid (PLEX_UID) as numeric values under extraEnv helm fails to deploy because the options are provided as integers instead of strings, regardless of how the values are provided within the values.yaml. For example all of these will fail to deployError Message:
Potential Solution: I've added quotations around the key/value pair that are land the env vars, if there is a more preferable solution I can update the pull request to accommodate. I've tested this solution works for me on my cluster.