Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect nesting of liveness and readiness probes #118

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

jpflouret
Copy link
Contributor

Liveness and readiness probes introduced in #117 are incorrectly nested within the resources template. Adding resource limits to the pms chart results in the following error:

Error: template: plex-media-server/templates/statefulset.yaml:123:28: executing "plex-media-server/templates/statefulset.yaml" at <.Values.pms.livenessProbe>: nil pointer evaluating interface {}.pms

This change fixes that issue.

@jpflouret jpflouret requested a review from a team as a code owner December 31, 2024 17:45
@jpflouret
Copy link
Contributor Author

jpflouret commented Dec 31, 2024

I believe the checks are failing due to the fact that the liveness and readiness probes are by default empty which is not valid.

        livenessProbe:
          {}
        readinessProbe:
          {}

I think this error didn't materialize itself in the previous PR due to it being hidden by the resources error that this PR fixes.

@cilindrox cilindrox self-assigned this Dec 31, 2024
@cilindrox cilindrox added the chart: patch Patch version bump label Dec 31, 2024
@jpflouret
Copy link
Contributor Author

@MarshallAsch I think your commit is unsigned. Do you want me to redo the chart bump change and sign it myself?

@MarshallAsch
Copy link
Member

no thats okay. I havent fixed my signing key so my commits are all unsigned now (I can bypass that requirement)

@MarshallAsch MarshallAsch merged commit 7d56882 into plexinc:master Dec 31, 2024
1 check passed
@jpflouret jpflouret deleted the fix-chart-resources branch December 31, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart: patch Patch version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants