Helm chart: Add the ability to use a pre existing peristent volume claim #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cilindrox
reviewed
Feb 26, 2024
There was a problem hiding this comment.
LGTM - thanks @jpflouret - Could you bump the Chart.version a minor so we can release this?
|
Suggestions applied. I could squash the commit with the review suggestions if you prefer that. |
cilindrox
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
LGTM 👍 thanks @jpflouret !
I'll squash and merge this for release
|
I suppose I need to sign the commit as per the branch rules? I could ammed the commits with signature and force push to my branch. |
|
@jpflouret appreciate it! |
|
@cilindrox done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I have an existing persistent volume and persistent volume claim with my PMS database. I want to use this pvc with the PMS helm chart.
Solution
This PR uses a common helm pattern where the user can provide the name of a pre existing volume claim and the chart will configure the PMS container to use that claim instead of creating a volumeClaimTemplate.