newLine at end of @this(...) and @(...) are not part of content

[mkurz]

This is quite a simple fix and I am wondering why this wasn't addressed yet.

If you have a template that defines a constructor or takes arguments you will always have a newLine in front of your rendered content. People are complaining about this behaviour e.g here and I have seen other comments where people complain about the newLine behaviour of various twirl expressions. This PR fixes a (small) part of that complains.

E.g. given following template:

@(someVar:String)
This is my content

currently renders to the following two lines

This is my content

But actually it should be just one line, without the new line

This is my content

The same happens when you use this(...)

IMHO the newLine at the end of this(...) and @() should not be seens as part of the template. These two lines just define the constructor and the arguments for the render method, but have nothing to do with the content.

Eventually my fix will also remove a lot of newLines for many people because usually you template call other templates that call other templates ... etc. so you will end up with many ugly new lines no one needs or wants.

All my pr does is calling check("\n") after the argument lists which swallows a new line if there is one.

[richdougherty]

👍Thanks!

[mkurz]

@richdougherty So you are ok to merge this? Or want someone else to approve?

[marcospereira]

Thank you, @mkurz.

[marcospereira]

Backport to 1.3.x: a351758

[mkurz]

Great, thanks for backporting 😄