Add EmptyBody case #186
Merged
Add EmptyBody case #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An error occurs when using the following code.
```
ws.url(url).withRequestFilter(AhcCurlRequestLogger()).withQueryStringParameters("hey" -> "yo").get()
```
Prevent throw exception EmptyBody case.
marcospereira
approved these changes
Aug 28, 2017
|
Hi. I just ran into this problem, and was hoping to fix it by upgrading to 1.1.1. Now I realized that this fix is not backported and it still throws this exception for EmptyBody... Could this be backported / merged to the 1.x.x branch? @gmethvin ? |
marcospereira
pushed a commit
that referenced
this pull request
Oct 5, 2017
An error occurs when using the following code.
```
ws.url(url).withRequestFilter(AhcCurlRequestLogger()).withQueryStringParameters("hey" -> "yo").get()
```
Prevent throw exception EmptyBody case.
|
Backport to 1.x.x: 0892a7e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
add case EmptyBody case.
Purpose
Add EmptyBody case in CurlFormat trait.
Background Context
An error occurs when using the following code.
References
I can't found in Google search and Github issues.