[WIP] Drag and Drop Editing and Sample Editor #25

KetanReddy · 2023-01-17T17:46:28Z

📦 Published PR as canary version: 0.4.0--canary.25.1006

Try this version out locally by upgrading relevant packages to 0.4.0--canary.25.1006

codecov · 2023-01-18T14:21:29Z

Codecov Report

Patch coverage: 55.90% and project coverage change: -0.24 ⚠️

Comparison is base (ff92762) 55.32% compared to head (50b36f1) 55.08%.

❗ Current head 50b36f1 differs from pull request most recent head a4bda88. Consider uploading reports for the commit a4bda88 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   55.32%   55.08%   -0.24%     
==========================================
  Files          63       64       +1     
  Lines        3212     3342     +130     
  Branches      956      985      +29     
==========================================
+ Hits         1777     1841      +64     
- Misses       1098     1176      +78     
+ Partials      337      325      -12

Impacted Files	Coverage Δ
drag-and-drop/library/src/hooks/useDragAndDrop.tsx	`0.00% <0.00%> (ø)`
...g-and-drop/library/src/hooks/useDraggableAsset.tsx	`0.00% <0.00%> (ø)`
language/dsl/src/compiler/schema.ts	`81.94% <ø> (ø)`
language/dsl/src/switch.tsx	`88.23% <ø> (ø)`
language/dsl/src/utils.tsx	`82.75% <ø> (ø)`
language/service/src/xlr/service.ts	`73.97% <ø> (ø)`
drag-and-drop/library/src/utils/drop-component.tsx	`11.76% <11.76%> (ø)`
...g-and-drop/library/src/hooks/useDroppableAsset.tsx	`14.28% <14.28%> (ø)`
drag-and-drop/library/src/controller.tsx	`48.64% <48.64%> (ø)`
...g-and-drop/library/src/utils/runtime-flow-state.ts	`52.94% <52.94%> (ø)`
... and 4 more

... and 55 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

KetanReddy · 2023-01-18T14:24:46Z

/canary

adierkens · 2023-01-20T20:45:59Z

/canary

adierkens · 2023-01-21T11:07:02Z

/canary

Moving the typescript filesystem mock for tests out of the utils package and into test helpers for the converters. Co-authored-by: Shawn Andrews <[email protected]>

KetanReddy · 2023-01-25T18:41:26Z

/canary

KetanReddy · 2023-02-01T22:03:22Z

/canary

…to feature/drag-and-drop

Updating Feature/drag and drop branch with latest.

KetanReddy · 2023-02-07T19:36:43Z

/canary

…rget assets

KetanReddy · 2023-02-08T18:50:47Z

/canary

…-to-handle-Drag-and-Drop-state-changes pass a callback to handle Drag and Drop state changes

KetanReddy · 2023-02-23T17:10:17Z

/canary

…in dnd library (#47) * feat: added ability to add player plugins that don't have a manifest in dnd library --------- Co-authored-by: Shawn Andrews <[email protected]>

KetanReddy · 2023-02-27T19:18:00Z

/canary

…nd-drop

…to feature/drag-and-drop

KetanReddy · 2023-03-03T20:52:05Z

/canary

KetanReddy · 2023-03-09T05:17:14Z

/canary

…asset

adierkens and others added 10 commits January 5, 2023 13:44

Save off progress

8fa423e

Save state

8ab70a3

Use XLR

14ddc32

Restyle and edit dropped assets

15592ea

WIP: scaffold for filling in required properties on assets

46f5c66

Add sample property panel

4a8c4fc

Cleanup modal for required props

6677c55

Modal for showing generated view

495cb80

Sidebar docs for assets

c8769ac

reorg so production build passes

6452bb0

KetanReddy added the minor Increment the minor version when merged label Jan 17, 2023

KetanReddy self-assigned this Jan 17, 2023

KetanReddy and others added 3 commits January 17, 2023 12:55

Undo removing workflows

5df2d9b

fix build - prevent webpack from default .mjs handling

c15841d

fix failing tests

aecfd37

Update to latest player version

42ac533

Use applyReact instead of applyWeb

d858b80

Move Test Helpers out of @player-tools/xlr-utils

364981f

Moving the typescript filesystem mock for tests out of the utils package and into test helpers for the converters. Co-authored-by: Shawn Andrews <[email protected]>

KetanReddy linked an issue Jan 30, 2023 that may be closed by this pull request

Error Thrown when Indexing Long Lists #35

Closed

KetanReddy added patch Increment the patch version when merged minor Increment the minor version when merged and removed minor Increment the minor version when merged patch Increment the patch version when merged labels Jan 30, 2023

KetanReddy removed a link to an issue Jan 31, 2023

Error Thrown when Indexing Long Lists #35

Closed

KetanReddy and others added 7 commits February 6, 2023 12:46

Fix dropped imports

b6972ff

Merge branch 'main' into feature/drag-and-drop

b68cb2b

Transform values key out to prevent Player from parsing it

c544e2e

Merge branch 'feature/drag-and-drop' of github.com:player-ui/tools in…

3ec921c

…to feature/drag-and-drop

Merge branch 'main' into feature/drag-and-drop

15d296b

test: added test-helpers for xlr/utils

1a61a36

Merge pull request #44 from sandrews06/feature/drag-and-drop

d52ac66

Updating Feature/drag and drop branch with latest.

Also take out any XLR info during the beforeResolve phase for drop-ta…

94ed219

…rget assets

Chengli Wang and others added 4 commits February 17, 2023 09:08

pass a callback to handle Drag and Drop state changes

3dcda7b

fix: Populates placeholder targets when importing existing content

fda1541

fix: moved removeDndStateFromView to a helper function

bbdf3fb

Merge pull request #46 from chengliwang/feat-pass-a-callback-function…

de99318

…-to-handle-Drag-and-Drop-state-changes pass a callback to handle Drag and Drop state changes

feat: added ability to add player plugins that don't have a manifest …

50b36f1

…in dnd library (#47) * feat: added ability to add player plugins that don't have a manifest in dnd library --------- Co-authored-by: Shawn Andrews <[email protected]>

KetanReddy added 5 commits February 27, 2023 16:04

Merge branch 'main' of github.com:player-ui/tools into feature/drag-a…

d87a1b9

…nd-drop

Merge branch 'feature/drag-and-drop' of github.com:player-ui/tools in…

e2844eb

…to feature/drag-and-drop

maintenance: move testing helpers into shared local package

e12d2c6

move xlr deserialization out of sdk and in to cli

9d63cb3

Run standard player transforms on XLR import

642c295

Add APIs for more operations, expose subscribe function

4ee940e

KetanReddy and others added 5 commits May 16, 2023 14:32

defer adding XLR info to transform

8fd2493

Fix bug preventing changing the asset being edited after updating an …

aa7f9c7

…asset

Place Assets from side bar (doesn't update sidebar though)

2a33ba9

Fix sidebar updates

922c223

Fix asset selecting not working

a4bda88

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Drag and Drop Editing and Sample Editor #25

[WIP] Drag and Drop Editing and Sample Editor #25

KetanReddy commented Jan 17, 2023 •

edited by intuit-svc

Loading

codecov bot commented Jan 18, 2023 •

edited

Loading

KetanReddy commented Jan 18, 2023

adierkens commented Jan 20, 2023

adierkens commented Jan 21, 2023

KetanReddy commented Jan 25, 2023

KetanReddy commented Feb 1, 2023

KetanReddy commented Feb 7, 2023

KetanReddy commented Feb 8, 2023

KetanReddy commented Feb 23, 2023

KetanReddy commented Feb 27, 2023

KetanReddy commented Mar 3, 2023

KetanReddy commented Mar 9, 2023

[WIP] Drag and Drop Editing and Sample Editor #25

Are you sure you want to change the base?

[WIP] Drag and Drop Editing and Sample Editor #25

Conversation

KetanReddy commented Jan 17, 2023 • edited by intuit-svc Loading

codecov bot commented Jan 18, 2023 • edited Loading

Codecov Report

KetanReddy commented Jan 18, 2023

adierkens commented Jan 20, 2023

adierkens commented Jan 21, 2023

KetanReddy commented Jan 25, 2023

KetanReddy commented Feb 1, 2023

KetanReddy commented Feb 7, 2023

KetanReddy commented Feb 8, 2023

KetanReddy commented Feb 23, 2023

KetanReddy commented Feb 27, 2023

KetanReddy commented Mar 3, 2023

KetanReddy commented Mar 9, 2023

KetanReddy commented Jan 17, 2023 •

edited by intuit-svc

Loading

codecov bot commented Jan 18, 2023 •

edited

Loading