Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing scroll depth #4979

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Handle missing scroll depth #4979

wants to merge 9 commits into from
+477 −157

Conversation

RobertJoonas
Copy link
Contributor

@RobertJoonas RobertJoonas commented Jan 15, 2025 •
edited
Loading

Changes

  • Add engagement_metrics_enabled_at, :naive_datetime field to site (todo: extract migration)
  • Start writing this field when user receives pageleaves (Note: current solution in this PR is not final)
  • Add an extra check next to the feature flag - if site.engagement_metrics_enabled_at is set, show scroll_depth on the dashboard + include it in dashboard CSV and Full CSV exports

Tests

  • Automated tests have been added

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@RobertJoonas RobertJoonas marked this pull request as draft January 15, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RobertJoonas