Skip to content

Commit

Permalink
Merge branch 'hotfix/v2.5.5'
Browse files Browse the repository at this point in the history
  • Loading branch information
ivankravets committed Oct 31, 2022
2 parents c143cad + 5d5cba2 commit a2eff52
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 13 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Release Notes

## 2.5.5 (2022-10-31)

- Inherit VSCode Proxy configuration for PlatformIO Core (requires PlatformIO Core 6.1.5+)
- Fixed an issue with passing VSCode environment variables to the terminal processes (issue [#3287](https://github.com/platformio/platformio-vscode-ide/issues/3287))

## 2.5.4 (2022-09-03)

- Keep using legacy API for calling VSCode tasks
Expand Down
14 changes: 7 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "platformio-ide",
"version": "2.5.4",
"version": "2.5.5",
"publisher": "platformio",
"engines": {
"vscode": "^1.63.0"
Expand Down Expand Up @@ -627,22 +627,22 @@
},
"dependencies": {
"fs-plus": "~3.1.1",
"platformio-node-helpers": "~9.6.0",
"platformio-node-helpers": "~9.6.1",
"platformio-vscode-debug": "~1.4.1"
},
"devDependencies": {
"@babel/core": "~7.18.13",
"@babel/eslint-parser": "~7.18.9",
"@babel/core": "~7.19.6",
"@babel/eslint-parser": "~7.19.1",
"@babel/plugin-proposal-class-properties": "~7.18.6",
"@babel/preset-env": "~7.18.10",
"@babel/preset-env": "~7.19.4",
"@types/node": "~14",
"@types/vscode": "~1.63.0",
"babel-loader": "~8.2.5",
"eslint": "~8.23.0",
"eslint": "~8.26.0",
"eslint-import-resolver-webpack": "~0.13.2",
"eslint-plugin-import": "~2.26.0",
"prettier": "~2.7.1",
"vsce": "~2.11.0",
"vsce": "~2.13.0",
"webpack": "~5.74.0",
"webpack-cli": "~4.10.0"
},
Expand Down
7 changes: 3 additions & 4 deletions src/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -132,13 +132,12 @@ class PlatformIOVSCodeExtension {
if (http_proxy && !process.env.HTTP_PROXY && !process.env.http_proxy) {
extraVars['HTTP_PROXY'] = http_proxy;
}
if (!vscode.workspace.getConfiguration('http').get('proxyStrictSSL')) {
// https://stackoverflow.com/questions/48391750/disable-python-requests-ssl-validation-for-an-imported-module
extraVars['CURL_CA_BUNDLE'] = '';
}
if (http_proxy && !process.env.HTTPS_PROXY && !process.env.https_proxy) {
extraVars['HTTPS_PROXY'] = http_proxy;
}
if (!vscode.workspace.getConfiguration('http').get('proxyStrictSSL')) {
extraVars['PLATFORMIO_SETTING_ENABLE_PROXY_STRICT_SSL'] = 'false';
}
if (this.getSetting('customPyPiIndexUrl')) {
extraVars['PIP_INDEX_URL'] = this.getSetting('customPyPiIndexUrl');
}
Expand Down
2 changes: 1 addition & 1 deletion src/project/tasks.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export default class ProjectTaskManager {
}

toVSCodeTask(projectTask) {
const envClone = Object.create(process.env);
const envClone = Object.assign({}, process.env);
if (process.env.PLATFORMIO_PATH) {
envClone.PATH = process.env.PLATFORMIO_PATH;
envClone.Path = process.env.PLATFORMIO_PATH;
Expand Down
2 changes: 1 addition & 1 deletion src/terminal.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default class PIOTerminal {
}

new() {
const envClone = Object.create(process.env);
const envClone = Object.assign({}, process.env);
if (process.env.PLATFORMIO_PATH) {
envClone.PATH = process.env.PLATFORMIO_PATH;
envClone.Path = process.env.PLATFORMIO_PATH;
Expand Down

0 comments on commit a2eff52

Please sign in to comment.