New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not throw if request is not found #4

Merged

ivan-tymoshenko merged 2 commits into main from do-not-throw-if-request-is-not-found

Oct 10, 2024

Member

ivan-tymoshenko commented Oct 10, 2024

This is needed for the case when the time line is the following:

server receives a request
server starts collecting metrics
server sends a response

ivan-tymoshenko added 2 commits

October 10, 2024 18:11


          fix: don't throw if request timer is not found

c7bb559


          add test

6d8ead4

ivan-tymoshenko requested review from mcollina and ShogunPanda

October 10, 2024 16:21

mcollina approved these changes

View reviewed changes

Member

mcollina left a comment

lgtm

ivan-tymoshenko merged commit cdfe3c0 into main

6 checks passed

ivan-tymoshenko deleted the do-not-throw-if-request-is-not-found branch

October 10, 2024 16:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet