Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed vulnerabilities found in Trivy scan #7

Merged

Conversation

deepak07dbz
Copy link

@deepak07dbz deepak07dbz commented Oct 21, 2024

fixed trivy vulns and changed image os from centos to alpine.

$ k get po -A | grep multus
luigi-system kube-multus-ds-amd64-kcftf 1/1 Running 0 18m

$ k describe -n luigi-system po/kube-multus-ds-amd64-kcftf | grep -i image
Image: quay.io/platform9/multus:v3.7.2-pmk-3440935
Image ID: quay.ioplatform9multus@sha256:132b84a4283a877ba8ef70e6fde2189b3592ac3d4434cae314eb60c4cdd9034a
Normal Pulling 20m kubelet Pulling image "quay.io/platform9/multus:v3.7.2-pmk-3440935"
Normal Pulled 20m kubelet Successfully pulled image "quay.io/platform9/multus:v3.7.2-pmk-3440935" in 7.492502632s (7.492629461s including waiting)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11438661854

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.202%

Totals Coverage Status
Change from base Build 11438013043: 0.0%
Covered Lines: 1213
Relevant Lines: 1805

💛 - Coveralls

@deepak07dbz deepak07dbz changed the title fixed missing mirrorlist fixed trivy vulns Nov 13, 2024
@cruizen
Copy link

cruizen commented Nov 13, 2024

@deepak07dbz can you check why the Github actions for build, test are failing - and then update them?

Run ./hack/build-go.sh
  ./hack/build-go.sh
  shell: /usr/bin/bash -e {0}
  env:
    GOARCH: 386
    GOOS: 
Building plugins
flag provided but not defined: -buildvcs
usage: go build [-o output] [build flags] [packages]
Run 'go help build' for details.
Error: Process completed with exit code [2](https://github.com/platform9/multus-cni/actions/runs/11796682793/job/32859072720?pr=7#step:4:2).
image

Copy link

@cruizen cruizen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add details on testing - commands to show the multus pod working etc.

deployments/Dockerfile Outdated Show resolved Hide resolved
deployments/Dockerfile Outdated Show resolved Hide resolved
@cruizen
Copy link

cruizen commented Nov 13, 2024

@deepak07dbz The GitHub actions have been updated in the master branch - e.g. they are passing on this PR #5
They may need further update e.g. to use new version of golang etc.

@cruizen cruizen changed the title fixed trivy vulns fixed vulnerabilities found in Trivy scan Nov 18, 2024
@cruizen cruizen self-requested a review November 18, 2024 08:49
Copy link

@cruizen cruizen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Please update the image and test in a SMCP testbed (5.11 branch)

@deepak07dbz deepak07dbz merged commit a4ebc4d into v3.7.2-branch Nov 18, 2024
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants