-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(token-cli): figma から得られる float に suffix px を付ける #657
Conversation
Visit the preview URL for this PR (updated for commit 68a3f2c): https://pixiv-charcoal-web--pr657-chore-css-variables-svr66a9m.web.app (expires Fri, 20 Dec 2024 10:28:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 314b26d3adca98a761c7e4d9922ebb206ff024a0 |
Size Change: +2 B (0%) Total Size: 540 kB
ℹ️ View Unchanged
|
26e1df9
to
0ff0283
Compare
0ff0283
to
075162d
Compare
@@ -136,6 +136,6 @@ export const resolveValue = ( | |||
|
|||
export const resolveColor = (value: Color) => colorToRgba(value) | |||
|
|||
export const resolveFloat = (value: number) => `${value}` | |||
export const resolveFloat = (value: number) => `${value}px` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0pxを0したほうがいいかもしれないがそれ以外大丈夫そうです
[theme]Update theme Fri Dec 13 2024
font-weightの場合pxつけじゃいけないでした |
やったこと
動作確認環境
チェックリスト
不要なチェック項目は消して構いません